You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "GH-Gloway (via GitHub)" <gi...@apache.org> on 2024/12/24 09:36:15 UTC
[PR] [CELEBORN-1737][BUILD]Include Tez client into binary release tarball [celeborn]
GH-Gloway opened a new pull request, #3028:
URL: https://github.com/apache/celeborn/pull/3028
### What changes were proposed in this pull request?
Add Tez packaging script
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737][BUILD]Include Tez client into binary release tarball [celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3028:
URL: https://github.com/apache/celeborn/pull/3028#issuecomment-2561014217
## [Codecov](https://app.codecov.io/gh/apache/celeborn/pull/3028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 32.68%. Comparing base [(`2eb4c23`)](https://app.codecov.io/gh/apache/celeborn/commit/2eb4c23eb8c87788daea66caa8e331e024d160b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a470611`)](https://app.codecov.io/gh/apache/celeborn/commit/a470611959e5dcb6525a5701b24c7d0c34bb1351?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 5 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 32.99% 32.68% -0.30%
==========================================
Files 331 336 +5
Lines 19842 20032 +190
Branches 1787 1792 +5
==========================================
+ Hits 6545 6546 +1
- Misses 12933 13123 +190
+ Partials 364 363 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celeborn/pull/3028?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737] Support build tez client package [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3028:
URL: https://github.com/apache/celeborn/pull/3028#issuecomment-2564571849
do you plan to have 2 modules likes other clients?
```
client-tez/tez
client-tez/tez-shaded
```
And could you enable the `tez` in https://github.com/apache/celeborn/blob/main/dev/dependencies.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737] Support build tez client package [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3028:
URL: https://github.com/apache/celeborn/pull/3028#discussion_r1899173266
##########
pom.xml:
##########
@@ -1804,10 +1804,11 @@
<id>tez</id>
<modules>
<module>client-tez/tez</module>
+ <module>client-tez/tez-shaded</module>
<module>tests/tez-it</module>
</modules>
<properties>
- <tez.version>0.10.3</tez.version>
+ <tez.version>0.10.2</tez.version>
Review Comment:
by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737] Support build tez client package [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #3028:
URL: https://github.com/apache/celeborn/pull/3028#issuecomment-2564720004
> do you plan to have 2 modules likes other clients?
>
> ```
> client-tez/tez
> client-tez/tez-shaded
> ```
>
> And could you enable the `tez` dependency check? https://github.com/apache/celeborn/blob/main/dev/dependencies.sh https://github.com/apache/celeborn/blob/main/.github/workflows/deps.yml
>
> Also, it is better to provide the checking result for the shaded jar.
>
> ```
> jar -tf $SHADED_JAR | grep -v celeborn | grep '\.class$'
> ```
I've updated this PR.
The dep check for SBT will come up with a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737] Support build tez client package [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3028:
URL: https://github.com/apache/celeborn/pull/3028#discussion_r1899153221
##########
build/make-distribution.sh:
##########
@@ -248,6 +248,24 @@ function build_mr_client {
cp "$PROJECT_DIR"/client-mr/mr-shaded/target/celeborn-client-mr-shaded_${SCALA_VERSION}-$VERSION.jar "$DIST_DIR/mr/"
}
+function build_tez_client {
+ VERSION=$("$MVN" help:evaluate -Dexpression=project.version $@ 2>/dev/null \
+ | grep -v "INFO" \
+ | grep -v "WARNING" \
+ | tail -n 1)
+ BUILD_COMMAND=("$MVN" clean package $MVN_DIST_OPT -pl :celeborn-client-tez-shaded_${SCALA_VERSION} -am $@)
+
+ # Actually build the jar
+ echo -e "\nBuilding with..."
+ echo -e "\$ ${BUILD_COMMAND[@]}\n"
+
+ "${BUILD_COMMAND[@]}"
+
+ ## flink spark client jars
Review Comment:
nit: seems typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1737] Support build tez client package [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #3028: [CELEBORN-1737] Support build tez client package
URL: https://github.com/apache/celeborn/pull/3028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org