You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2008/02/21 17:44:23 UTC
[math] MATH-195, MATH-193 and pending release VOTE
The 1.2 release VOTE is about to close, but during the vote these two
issues have been opened.
I have looked at both of these issues and am personally comfortable
with marking them as either for 2.0 or WONTFIX (most likely for
MATH-195), but I don't want to do this preemptively without giving
others the opportunity to weigh in. If others think these need to be
addressed in 1.2, I will stop the VOTE and we can address them;
otherwise I would prefer to proceed with the release when the VOTE
closes, after marking the issues for 2.0.
I think the fixes in MATH-193 are valid, but not worth holding the
release for. While I appreciate the feedback in MATH-193, I can't
endorse any of the recommended changes, either because I disagree with
them or for backward compatability issues. Other opinions welcome.
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] MATH-195, MATH-193 and pending release VOTE
Posted by Phil Steitz <ph...@gmail.com>.
Sorry, I meant MATH-195 in the second to last sentence below.
On 2/21/08, Phil Steitz <ph...@gmail.com> wrote:
> The 1.2 release VOTE is about to close, but during the vote these two
> issues have been opened.
>
> I have looked at both of these issues and am personally comfortable
> with marking them as either for 2.0 or WONTFIX (most likely for
> MATH-195), but I don't want to do this preemptively without giving
> others the opportunity to weigh in. If others think these need to be
> addressed in 1.2, I will stop the VOTE and we can address them;
> otherwise I would prefer to proceed with the release when the VOTE
> closes, after marking the issues for 2.0.
>
> I think the fixes in MATH-193 are valid, but not worth holding the
> release for. While I appreciate the feedback in MATH-193, I can't
> endorse any of the recommended changes, either because I disagree with
> them or for backward compatability issues. Other opinions welcome.
>
> Phil
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] MATH-195, MATH-193 and pending release VOTE
Posted by Michael Heuer <he...@acm.org>.
Luc Maisonobe wrote:
> Phil Steitz a �crit :
> > The 1.2 release VOTE is about to close, but during the vote these two
> > issues have been opened.
> >
> > I have looked at both of these issues and am personally comfortable
> > with marking them as either for 2.0 or WONTFIX (most likely for
> > MATH-195), but I don't want to do this preemptively without giving
> > others the opportunity to weigh in. If others think these need to be
> > addressed in 1.2, I will stop the VOTE and we can address them;
> > otherwise I would prefer to proceed with the release when the VOTE
> > closes, after marking the issues for 2.0.
>
> MATH-193 concerns minors issues that will be better handled as routine
> maintenance will start again after the release.
That is fine with me. Sorry I couldn't get those in quicker -- you and
Phil are too efficient. :)
michael
> MATH-195 seems an interesting approach to me, but really needs to be
> discussed before being either accepted or rejected. Since changing from
> checked to unchecked exception is an incompatible change, it cannot be
> done before 1.2 release.
>
> Luc
>
> >
> > I think the fixes in MATH-193 are valid, but not worth holding the
> > release for. While I appreciate the feedback in MATH-193, I can't
> > endorse any of the recommended changes, either because I disagree with
> > them or for backward compatability issues. Other opinions welcome.
> >
> > Phil
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] MATH-195, MATH-193 and pending release VOTE
Posted by Luc Maisonobe <Lu...@free.fr>.
Phil Steitz a écrit :
> The 1.2 release VOTE is about to close, but during the vote these two
> issues have been opened.
>
> I have looked at both of these issues and am personally comfortable
> with marking them as either for 2.0 or WONTFIX (most likely for
> MATH-195), but I don't want to do this preemptively without giving
> others the opportunity to weigh in. If others think these need to be
> addressed in 1.2, I will stop the VOTE and we can address them;
> otherwise I would prefer to proceed with the release when the VOTE
> closes, after marking the issues for 2.0.
MATH-193 concerns minors issues that will be better handled as routine
maintenance will start again after the release.
MATH-195 seems an interesting approach to me, but really needs to be
discussed before being either accepted or rejected. Since changing from
checked to unchecked exception is an incompatible change, it cannot be
done before 1.2 release.
Luc
>
> I think the fixes in MATH-193 are valid, but not worth holding the
> release for. While I appreciate the feedback in MATH-193, I can't
> endorse any of the recommended changes, either because I disagree with
> them or for backward compatability issues. Other opinions welcome.
>
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [math] MATH-195, MATH-193 and pending release VOTE
Posted by sebb <se...@gmail.com>.
On 21/02/2008, Phil Steitz <ph...@gmail.com> wrote:
> The 1.2 release VOTE is about to close, but during the vote these two
> issues have been opened.
>
> I have looked at both of these issues and am personally comfortable
> with marking them as either for 2.0 or WONTFIX (most likely for
> MATH-195), but I don't want to do this preemptively without giving
> others the opportunity to weigh in. If others think these need to be
> addressed in 1.2, I will stop the VOTE and we can address them;
> otherwise I would prefer to proceed with the release when the VOTE
> closes, after marking the issues for 2.0.
>
> I think the fixes in MATH-193 are valid, but not worth holding the
> release for. While I appreciate the feedback in MATH-193, I can't
> endorse any of the recommended changes, either because I disagree with
> them or for backward compatability issues. Other opinions welcome.
>
Although the Javadoc fixes in MATH-193 make the text agree with the
parameter names, I think that's not the best solution.
Short parameter names like "d" are easy to type in code, but they
don't work well for IDEs that provide completion hints, e.g. when
calling the methods from other code. For example, rather than:
public RealMatrixImpl(double[][] d)
it would be clearer to use something more descriptive, e.g.:
public RealMatrixImpl(double[][] sourcedata)
I would suggest deferring the changes.
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org