You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by jcabrerizo <gi...@git.apache.org> on 2018/11/07 16:57:53 UTC
[GitHub] brooklyn-ui pull request #98: Add compact list view mode
GitHub user jcabrerizo opened a pull request:
https://github.com/apache/brooklyn-ui/pull/98
Add compact list view mode
Added new compact list view mode to the palette with small icons and the full description
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcabrerizo/brooklyn-ui jcCompactList
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit cb074a5c4210fcc5bff57bbd490d5a3077b71e29
Author: Juan Cabrerizo <ju...@...>
Date: 2018-11-07T16:41:39Z
add compact list view mode
----
---
[GitHub] brooklyn-ui issue #98: Add compact list view mode
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-ui/pull/98
one minor code comment, otherwise good to merge. nice addition.
@jcabrerizo have you filed an ICLA ? (see http://brooklyn.apache.org/developers/how-to-contribute.html ) -- we need that also before we can merge
---
[GitHub] brooklyn-ui issue #98: Add compact list view mode
Posted by jcabrerizo <gi...@git.apache.org>.
Github user jcabrerizo commented on the issue:
https://github.com/apache/brooklyn-ui/pull/98
Conflicts resolved
---
[GitHub] brooklyn-ui issue #98: Add compact list view mode
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-ui/pull/98
cool, just that fix then. and, i've just noticed, this has conflicts with #97 which i've merged. should be easy to resolve, i think it's the fix to the watch group you added that needs to be reapplied.
---
[GitHub] brooklyn-ui pull request #98: Add compact list view mode
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/98
---
[GitHub] brooklyn-ui issue #98: Add compact list view mode
Posted by jcabrerizo <gi...@git.apache.org>.
Github user jcabrerizo commented on the issue:
https://github.com/apache/brooklyn-ui/pull/98
Yes, I did it a couple of weeks ago
---