You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/01/05 06:57:00 UTC
[jira] [Commented] (THRIFT-4652) Some go documentation on the
website needs to be updated
[ https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734792#comment-16734792 ]
James E. King III commented on THRIFT-4652:
-------------------------------------------
Please check and see if the content is updated to your satisfaction now - if so, please resolve/close this item as Done.
> Some go documentation on the website needs to be updated
> --------------------------------------------------------
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
> Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
> Reporter: Tristian Azura
> Assignee: James E. King III
> Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)