You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 12:31:22 UTC
[GitHub] [flink] danny0405 commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in
planner
danny0405 commented on a change in pull request #10098: [FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343049291
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/FunctionIdentifier.java
##########
@@ -87,6 +94,23 @@ public static ObjectIdentifier normalizeObjectIdentifier(ObjectIdentifier oi) {
return Optional.ofNullable(functionName);
}
+ /**
+ * List of the components of this function identifier.
+ */
+ public List<String> getNames() {
+ if (objectIdentifier != null) {
Review comment:
Because it is immutable, we can just holds a public final member named `names`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services