You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/29 18:51:33 UTC
[GitHub] hetong007 commented on a change in pull request #12998: remove
legacy installation of Roxygen2 5.0 and add R-specific clean target (#12993)
hetong007 commented on a change in pull request #12998: remove legacy installation of Roxygen2 5.0 and add R-specific clean target (#12993)
URL: https://github.com/apache/incubator-mxnet/pull/12998#discussion_r229055081
##########
File path: Makefile
##########
@@ -584,14 +584,15 @@ rpkg:
cp -rf 3rdparty/tvm/nnvm/include/* R-package/inst/include
Rscript -e "if(!require(devtools)){install.packages('devtools', repo = 'https://cloud.r-project.org/')}"
Rscript -e "library(devtools); library(methods); options(repos=c(CRAN='https://cloud.r-project.org/')); install_deps(pkg='R-package', dependencies = TRUE)"
- echo "import(Rcpp)" > R-package/NAMESPACE
- echo "import(methods)" >> R-package/NAMESPACE
+ cp R-package/dummy.NAMESPACE R-package/NAMESPACE
Review comment:
Can you point me to some source on how `R CMD INSTALL` deal with `dummy.NAMESPACE`? Seems it is automatically ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services