[jira] [Updated] (EMAIL-101) Specified Content-ID is not used when embedding a File object in an HtmlEmail

["Thomas Neidhart (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart updated EMAIL-101:
----------------------------------

    Attachment: EMAIL-101_encoding.patch

Added an updated patch for the broken inline images. The cid has to be encoded properly (see http://tools.ietf.org/html/rfc2392).
                
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
>                 Key: EMAIL-101
>                 URL: https://issues.apache.org/jira/browse/EMAIL-101
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.0, 1.1, 1.2
>            Reporter: Andrew Starodub
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: EMAIL-101_encoding.patch, EMAIL-101.patch, HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method. 
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time. 
> I believe this is as simple as changing the last line of .embed(File file, String cid) from: 
> return embed(new FileDataSource(file), file.getName());
> To: 
> return embed(new FileDataSource(file), file.getName(), cid);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira