You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Greg Huber (JIRA)" <ji...@apache.org> on 2017/05/11 15:20:04 UTC

[jira] [Comment Edited] (WW-4762) DefaultLocalizedTextProvider refactoring

    [ https://issues.apache.org/jira/browse/WW-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006623#comment-16006623 ] 

Greg Huber edited comment on WW-4762 at 5/11/17 3:19 PM:
---------------------------------------------------------

ok, I copied the tiles plugin also (and now the tiles error is gone and it works).

When i add

```xml
<constant name="struts.localizedTextProvider" value="default-only" />
```

I get get this (core jar)
SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location]

#####
To make it work : 

```xml
<constant name="struts.localizedTextProvider" value="default-only" />
```
and then update my :

struts.custom.i18n.resources=ApplicationResources

to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 100+ files as they are validator message.properties etc

ie
struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit





was (Author: gregh99):
ok, I copied the tiles plugin also (and now the tiles error is gone and it works).

When i add

```xml
<constant name="struts.localizedTextProvider" value="default-only" />
```

I get now get this (core jar)
SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location]

#####
To make it work : 

```xml
<constant name="struts.localizedTextProvider" value="default-only" />
```
and then update my :

struts.custom.i18n.resources=ApplicationResources

to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 100+ files as they are validator message.properties etc

ie
struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit




> DefaultLocalizedTextProvider refactoring
> ----------------------------------------
>
>                 Key: WW-4762
>                 URL: https://issues.apache.org/jira/browse/WW-4762
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Greg Huber
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.5.next
>
>
> Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the code to allow an override so we can change the default behavior on the package searching for the resource.properties files.  Currently is does an extensive search up the class interfaces first which on busy screens slows things down and is an unnecessary overhead. 
> ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties file and are shared across struts ui classes in various packages. I would not want to duplicate the .properties entries for maintenance etc.
> I would then want to search the default ApplicationResources.properties first and then package class (for validation messages) and then possibly up the interfaces (which would not make sense for me as I do not use this logic).
> Discussion related to this
> http://markmail.org/message/v2oc6c35swfwzwid



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)