[GitHub] aaronmarkham commented on a change in pull request #13149: Fix Sphinx python docstring error: text contrib module (#12949)

[GitBox <gi...@apache.org>]

aaronmarkham commented on a change in pull request #13149: Fix Sphinx python docstring error: text contrib module (#12949)
URL: https://github.com/apache/incubator-mxnet/pull/13149#discussion_r231635205
 
 

 ##########
 File path: python/mxnet/contrib/text/embedding.py
 ##########
 @@ -506,25 +506,6 @@ class GloVe(_TokenEmbedding):
         embedding vectors, such as loaded from a pre-trained token embedding file. If None, all the
         tokens from the loaded embedding vectors, such as loaded from a pre-trained token embedding
         file, will be indexed.
-
-
-    Properties
-    ----------
-    token_to_idx : dict mapping str to int
-        A dict mapping each token to its index integer.
-    idx_to_token : list of strs
-        A list of indexed tokens where the list indices and the token indices are aligned.
-    unknown_token : hashable object
-        The representation for any unknown token. In other words, any unknown token will be indexed
-        as the same representation.
-    reserved_tokens : list of strs or None
-        A list of reserved tokens that will always be indexed.
-    vec_len : int
-        The length of the embedding vector for each token.
-    idx_to_vec : mxnet.ndarray.NDArray
 
 Review comment:
   I don't see this being added back elsewhere...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services