You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/11/24 15:59:00 UTC

[jira] [Commented] (PARQUET-2385) Don't initialize CodecFactory in ParquetWriter

    [ https://issues.apache.org/jira/browse/PARQUET-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789508#comment-17789508 ] 

ASF GitHub Bot commented on PARQUET-2385:
-----------------------------------------

amousavigourabi opened a new pull request, #1203:
URL: https://github.com/apache/parquet-mr/pull/1203

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   




> Don't initialize CodecFactory in ParquetWriter
> ----------------------------------------------
>
>                 Key: PARQUET-2385
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2385
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Atour Mousavi Gourabi
>            Priority: Major
>
> In ParquetWriter we initialize a CodecFactory, instead we should allow users to set their own via the builder as to provide a little more flexibility (analogous to PARQUET-2282).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)