You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/21 12:52:10 UTC

[GitHub] [royale-asjs] yishayw opened a new issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

yishayw opened a new issue #943:
URL: https://github.com/apache/royale-asjs/issues/943


   In this app
   
   ```
   <?xml version="1.0" encoding="utf-8"?>
   <s:Application 
   	xmlns:fx="http://ns.adobe.com/mxml/2009"
   	xmlns:s="library://ns.apache.org/royale/spark"
   	width="100%"
   	height="100%"
   	>
   	<fx:Script>
   		<![CDATA[
   			import spark.components.BorderContainer;
   
   			private function onClick():void
   			{
   				var bc:BorderContainer = new BorderContainer();
   				bc.percentWidth = 100;
   				bc.height = 200;
   				bc.setStyle("backgroundColor", "red");
   				bottomContainer.addElement(bc);
   			}
   		]]>
   	</fx:Script>		
   	<s:Scroller id="topContainer" width="100%">
   		<s:Group id="bottomContainer" width="100%" height="100%"/>
   	</s:Scroller>
   	<s:Button label="click" click="onClick()" bottom="0"/>
   </s:Application>
   
   ```
   
   Clicking on the button should show the red border container as it does in Flex.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

yishayw commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731584474


   Actually, Group doesn't resize either. @aharui , any thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] aharui commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

aharui commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731859027


   Test the branch for what?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

yishayw commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731588953


   Work around is to add
   
   				dispatchEvent(new Event("layoutNeeded"));
   
   at the end of onClick()
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

yishayw commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731705605


   Thanks, @aharui . Did you get a chance to test this branch? Also, includeInLayout change has the same issues and should probably be given the same treatment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

yishayw commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731579253


   It looks like Flex takes care of it when contentGroup of application skin is picked up by the layout manager. Also worth mentioning is that replacing Scroller with Group fixes this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] aharui commented on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

aharui commented on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731697876


   There is a ChildResize branch that has changes that force re-layout when children are added and removed.  I don't think it has been merged to the develop branch.  There might be changes in there that are useful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw edited a comment on issue #943: Spark Scroller Not Being Sized To Content When Elements Are Dynamically Added

Posted by GitBox <gi...@apache.org>.

yishayw edited a comment on issue #943:
URL: https://github.com/apache/royale-asjs/issues/943#issuecomment-731705605


   Thanks, @aharui . Did you get a chance to test this branch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org