You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Pierre Smits <pi...@gmail.com> on 2014/01/07 11:37:09 UTC

JIRA issue OFBIZ-5458 new branch request.

Hi all,

Would you please be so kind to create for each issue a new branch.

*Re OFBIZ-5458 <https://issues.apache.org/jira/browse/OFBIZ-5458>*
This improvement issue deals with the aspect of retrieving default values
from the database and as a failover from .properties files. Currently there
are over 1200 elements in .properties files providing the default/failover
data values used throughout the system through the getPropertyValue
function in UtilProperties.java.  Most are intended for a production
environment.  In a multi tenant setup this is inadequate as these
default/failover data values can (and most likely will) differ per tenant.
As a result the function getPropertyValue in EntityUtilProperties.java was
created to first pull data values from the table SystemProperty and as a
failover pull from a .properties file through the earlier mentioned
function in UtilProperties.java.

Unfortunately, the usage of the function in the various apps/components is
sparingly applied and in several cases with a hard coded default value.
Correcting this is a huge undertaking that isn't resolved immediately as it
impacts various function (screen, form, groovy, ftl and java) and
(expected) data files.

As I am willing to undertake the endeavour to correct this and, I request a
new branch to separate these modifications from trunk. So that the
improvement can be assessed seperately, and when completed (and accepted)
migrated back to trunk.

Regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: JIRA issue OFBIZ-5458 new branch request.

Posted by Adrian Crum <ad...@sandglass-software.com>.
Creating a branch is not a problem, but first we need to determine if a 
branch is really necessary. Let's finish the discussion in the Jira 
issue before we create a branch.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/7/2014 5:37 AM, Pierre Smits wrote:
> Hi all,
>
> Would you please be so kind to create for each issue a new branch.
>
> *Re OFBIZ-5458 <https://issues.apache.org/jira/browse/OFBIZ-5458>*
> This improvement issue deals with the aspect of retrieving default values
> from the database and as a failover from .properties files. Currently there
> are over 1200 elements in .properties files providing the default/failover
> data values used throughout the system through the getPropertyValue
> function in UtilProperties.java.  Most are intended for a production
> environment.  In a multi tenant setup this is inadequate as these
> default/failover data values can (and most likely will) differ per tenant.
> As a result the function getPropertyValue in EntityUtilProperties.java was
> created to first pull data values from the table SystemProperty and as a
> failover pull from a .properties file through the earlier mentioned
> function in UtilProperties.java.
>
> Unfortunately, the usage of the function in the various apps/components is
> sparingly applied and in several cases with a hard coded default value.
> Correcting this is a huge undertaking that isn't resolved immediately as it
> impacts various function (screen, form, groovy, ftl and java) and
> (expected) data files.
>
> As I am willing to undertake the endeavour to correct this and, I request a
> new branch to separate these modifications from trunk. So that the
> improvement can be assessed seperately, and when completed (and accepted)
> migrated back to trunk.
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>