You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/06 08:13:38 UTC
[GitHub] [iotdb] tieredblocks opened a new issue #1804: Small recommendation in IoTDBConnection
tieredblocks opened a new issue #1804:
URL: https://github.com/apache/iotdb/issues/1804
_Its not a bug but a suggestion._
In **[IoTDBConnection](https://github.com/apache/iotdb/blob/master/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java)** java file, can we make following changes to the code:
- Replace **throw new SQLException("Not support .......")** to **throw new SQLException("Does not support .......")** or **throw new SQLException("No support for .......")** in the applicable methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou closed issue #1804: Small recommendation in IoTDBConnection
Posted by GitBox <gi...@apache.org>.
HTHou closed issue #1804:
URL: https://github.com/apache/iotdb/issues/1804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on issue #1804: Small recommendation in IoTDBConnection
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on issue #1804:
URL: https://github.com/apache/iotdb/issues/1804#issuecomment-707012702
Hi, thank you, it is fine. Would you like to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tieredblocks commented on issue #1804: Small recommendation in IoTDBConnection
Posted by GitBox <gi...@apache.org>.
tieredblocks commented on issue #1804:
URL: https://github.com/apache/iotdb/issues/1804#issuecomment-712106477
Sure, will do this and upload the forked code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on issue #1804: Small recommendation in IoTDBConnection
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on issue #1804:
URL: https://github.com/apache/iotdb/issues/1804#issuecomment-768239006
PR https://github.com/apache/iotdb/pull/2278
The PR needs to be maintained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org