[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1006: Move stm32 common board logic to stm32/common/

[GitBox <gi...@apache.org>]

patacongo edited a comment on pull request #1006:
URL: https://github.com/apache/incubator-nuttx/pull/1006#issuecomment-625891529


   > I'm not sure how to handle license headers now with Apache. I would be probably moving around existing files (currently with BSD header) and modifying them. Should I change the header into Apache? Should I add a second header?
   
   All new files requires an Apache 2.0 header.  You can always just move an existing file (which is still not new) and edit it as necessary without changing the header.  If you have multiple choices for which version to common into the common version, select one that already has an Apache 2.0 license or, there is none, select one that I am the sole Copyright holder in the BSD header.
   
   If I am the ONLY copyright holder holder then you can free to replace my BSD copyright header with the Apache 2.0 header (use the one from sched/sched/sched_getcpu.c so that we keep the same line width).  You can do that first, because I grant permission but more importantly because I have signed and SGA, granting the code to the ASF.
   
   The worst case is that there is no source for the common code that has an Apache license or for which I am the sole Copyright holder.  In that case, I get confused.  But I think we have to copy the BSD header with no changes.  To me that is ugly... Engineers hate inconsistencies.  But I think that is what we have to do.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org