You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/05 03:10:33 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1486: [CALCITE-3388] StackOverflowError for creating structured RelDataType from class type

hsyuan commented on a change in pull request #1486: [CALCITE-3388] StackOverflowError for creating structured RelDataType from class type
URL: https://github.com/apache/calcite/pull/1486#discussion_r331730106
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
 ##########
 @@ -69,17 +69,34 @@ public JavaTypeFactoryImpl(RelDataTypeSystem typeSystem) {
     super(typeSystem);
   }
 
+  /**
+   * Create a structured {@link RelDataType} from java type,
+   * throw exception if recursion founded.
 
 Review comment:
   if recursion is found.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services