You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/02 20:19:03 UTC
[jira] [Commented] (AIRFLOW-4127) Azure Container Instance Hook
_get_instance_view bug
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808118#comment-16808118 ]
ASF subversion and git services commented on AIRFLOW-4127:
----------------------------------------------------------
Commit 7e184fca8c86a884f706ec789adc10973fc001f5 in airflow's branch refs/heads/v1-10-test from Asgeir Berland
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7e184fc ]
[AIRFLOW-4127] Correct AzureContainerInstanceHook._get_instance_view's return (#4945)
> Azure Container Instance Hook _get_instance_view bug
> ----------------------------------------------------
>
> Key: AIRFLOW-4127
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4127
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 2.0.0
> Reporter: Asgeir Berland
> Assignee: Asgeir Berland
> Priority: Major
> Labels: easyfix
> Fix For: 1.10.3
>
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> Code:
> [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/azure_container_instance_hook.py#L116]
>
> The ".current_state" needs to be stripped from the return call in this method. You can easily see why if you look at line107 and line129, which expects an "instance_view" and not "current_state".
> {code}
> return response.containers[0].instance_view.current_state
> ->
> return response.containers[0].instance_view
> {code}
> The current state of this bug makes it impossible to poll containers for status which is essential to detect when they have terminated their jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)