You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by Todd Lipcon <to...@cloudera.com> on 2011/02/11 04:45:25 UTC

Add Guava as a dependency?

Anyone mind if I pull in the Guava library as a dependency for Common? It
has a bunch of very useful utilities - in this particular case the one I'm
itching to use is ThreadFactoryBuilder:

http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html

More info here:
http://code.google.com/p/guava-libraries/

-Todd
-- 
Todd Lipcon
Software Engineer, Cloudera

Re: Add Guava as a dependency?

Posted by Mathias Herberts <ma...@gmail.com>.
+1, Guava is the magical piece that can get rid of all those
UnsupportedEncodingException ...!

Re: Add Guava as a dependency?

Posted by Arun C Murthy <ac...@yahoo-inc.com>.
+1

Arun

On Feb 10, 2011, at 7:45 PM, Todd Lipcon wrote:

> Anyone mind if I pull in the Guava library as a dependency for  
> Common? It
> has a bunch of very useful utilities - in this particular case the  
> one I'm
> itching to use is ThreadFactoryBuilder:
>
> http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html
>
> More info here:
> http://code.google.com/p/guava-libraries/
>
> -Todd
> -- 
> Todd Lipcon
> Software Engineer, Cloudera

Re: Add Guava as a dependency?

Posted by Owen O'Malley <om...@apache.org>.
On Feb 11, 2011, at 10:01 AM, Todd Lipcon wrote:

> Cool, seems like enough people are on board. I'll just include this  
> in the
> patch for HADOOP-7132 (naming the IPC Reader Threads) since that's  
> where I
> wanted to use it.
>
> Can't wait to use this stuff in more patches. I love guava :)

+1 on using Guava, although there was resistance to adding any new  
libraries to the classpath. I think that using well designed and  
supported libraries is much better than rolling custom code.

-- Owen

Re: Add Guava as a dependency?

Posted by Todd Lipcon <to...@cloudera.com>.
Cool, seems like enough people are on board. I'll just include this in the
patch for HADOOP-7132 (naming the IPC Reader Threads) since that's where I
wanted to use it.

Can't wait to use this stuff in more patches. I love guava :)

-Todd

On Fri, Feb 11, 2011 at 4:09 AM, Luke Lu <ll...@vicaya.com> wrote:

> +1. guava is the new apache commons, maintained by java experts with
> comprehensive test coverage.
>
> I also propose to deprecate any existing utils in hadoop-common with
> duplicate functionality.
>
> On Thu, Feb 10, 2011 at 10:25 PM, Jakob Homan <jg...@gmail.com> wrote:
> > +1
> >
> > On Thu, Feb 10, 2011 at 10:04 PM, Konstantin Boudnik <co...@apache.org>
> wrote:
> >> Actually it seems that Pig uses this already, which perhaps means it
> >> is good enough for us as well ;)
> >> --
> >>   Take care,
> >> Konstantin (Cos) Boudnik
> >>
> >> On Thu, Feb 10, 2011 at 19:45, Todd Lipcon <to...@cloudera.com> wrote:
> >>> Anyone mind if I pull in the Guava library as a dependency for Common?
> It
> >>> has a bunch of very useful utilities - in this particular case the one
> I'm
> >>> itching to use is ThreadFactoryBuilder:
> >>>
> >>>
> http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html
> >>>
> >>> More info here:
> >>> http://code.google.com/p/guava-libraries/
> >>>
> >>> -Todd
> >>> --
> >>> Todd Lipcon
> >>> Software Engineer, Cloudera
> >>>
> >>
> >
>



-- 
Todd Lipcon
Software Engineer, Cloudera

Re: Add Guava as a dependency?

Posted by Luke Lu <ll...@vicaya.com>.
+1. guava is the new apache commons, maintained by java experts with
comprehensive test coverage.

I also propose to deprecate any existing utils in hadoop-common with
duplicate functionality.

On Thu, Feb 10, 2011 at 10:25 PM, Jakob Homan <jg...@gmail.com> wrote:
> +1
>
> On Thu, Feb 10, 2011 at 10:04 PM, Konstantin Boudnik <co...@apache.org> wrote:
>> Actually it seems that Pig uses this already, which perhaps means it
>> is good enough for us as well ;)
>> --
>>   Take care,
>> Konstantin (Cos) Boudnik
>>
>> On Thu, Feb 10, 2011 at 19:45, Todd Lipcon <to...@cloudera.com> wrote:
>>> Anyone mind if I pull in the Guava library as a dependency for Common? It
>>> has a bunch of very useful utilities - in this particular case the one I'm
>>> itching to use is ThreadFactoryBuilder:
>>>
>>> http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html
>>>
>>> More info here:
>>> http://code.google.com/p/guava-libraries/
>>>
>>> -Todd
>>> --
>>> Todd Lipcon
>>> Software Engineer, Cloudera
>>>
>>
>

Re: Add Guava as a dependency?

Posted by Jakob Homan <jg...@gmail.com>.
+1

On Thu, Feb 10, 2011 at 10:04 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Actually it seems that Pig uses this already, which perhaps means it
> is good enough for us as well ;)
> --
>   Take care,
> Konstantin (Cos) Boudnik
>
> On Thu, Feb 10, 2011 at 19:45, Todd Lipcon <to...@cloudera.com> wrote:
>> Anyone mind if I pull in the Guava library as a dependency for Common? It
>> has a bunch of very useful utilities - in this particular case the one I'm
>> itching to use is ThreadFactoryBuilder:
>>
>> http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html
>>
>> More info here:
>> http://code.google.com/p/guava-libraries/
>>
>> -Todd
>> --
>> Todd Lipcon
>> Software Engineer, Cloudera
>>
>

Re: Add Guava as a dependency?

Posted by Konstantin Boudnik <co...@apache.org>.
Actually it seems that Pig uses this already, which perhaps means it
is good enough for us as well ;)
--
  Take care,
Konstantin (Cos) Boudnik

On Thu, Feb 10, 2011 at 19:45, Todd Lipcon <to...@cloudera.com> wrote:
> Anyone mind if I pull in the Guava library as a dependency for Common? It
> has a bunch of very useful utilities - in this particular case the one I'm
> itching to use is ThreadFactoryBuilder:
>
> http://guava-libraries.googlecode.com/svn/tags/release05/javadoc/com/google/common/util/concurrent/ThreadFactoryBuilder.html
>
> More info here:
> http://code.google.com/p/guava-libraries/
>
> -Todd
> --
> Todd Lipcon
> Software Engineer, Cloudera
>