You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "dschneider-pivotal (GitHub)" <gi...@apache.org> on 2018/12/07 01:28:06 UTC
[GitHub] [geode] dschneider-pivotal opened pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] monkeyherder commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "monkeyherder (GitHub)" <gi...@apache.org>.
@Petahhh This should be fixed. Can you review new changes and approve?
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on issue #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
The dunit failure looks like a known issue: https://issues.apache.org/jira/browse/GEODE-1920.
The unit test failures are a known issue.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
We named it "ids" here because we know in the near future it will support multiple column names instead of just one.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #2969: GEODE-6156:
add --id option to create jdbc-mapping
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
inexactly is one word. Can you change this to "givenColumnAndNonNullIdsThatDoesInexactlyMatchThenKeyColumnNameIsReturned"
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "agingade (GitHub)" <gi...@apache.org>.
It holds only one field name info; probably "id" instead of "ids".
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "agingade (GitHub)" <gi...@apache.org>.
How about overloaded RegionMapping constructor to avoid passing null.
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
I think it is best for this constructor to just like you initialize everything. This class represents a cache.xml element
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2969:
GEODE-6156: add --id option to create jdbc-mapping
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
will do
[ Full content available at: https://github.com/apache/geode/pull/2969 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org