[GitHub] [netbeans] tmysik commented on a diff in pull request #4240: [NETBEANS-5599] PHP 8.1 Support: First class callable syntax

[GitBox <gi...@apache.org>]

tmysik commented on code in PR #4240:
URL: https://github.com/apache/netbeans/pull/4240#discussion_r901120303


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCompletionItem.java:
##########
@@ -134,10 +134,11 @@ public abstract class PHPCompletionItem implements CompletionProposal {
     private QualifiedNameKind generateAs;
     private static ScheduledExecutorService service = Executors.newSingleThreadScheduledExecutor();
     private static final Cache<FileObject, PhpLanguageProperties> PROPERTIES_CACHE
-            = new Cache<>(new WeakHashMap<FileObject, PhpLanguageProperties>());
+            = new Cache<>(new WeakHashMap<>());
     private final boolean isPlatform;
     private final boolean isDeprecated;
     private PhpVersion phpVersion;
+    private static Boolean ADD_FIRST_CLASS_CALLABLE = null; // for unit tests

Review Comment:
   I think this field should be `volatile`, no? Or is always read/written in just one thread? If so, please document it. Thank you.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists