You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by GitBox <gi...@apache.org> on 2020/10/10 22:32:37 UTC

[GitHub] [uima-uimaj] reckart opened a new pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

reckart opened a new pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62


   - Added utility class with predicates for overlap/containment/etc of annotations
   - Added convenience access to these methods to the AnnotationFS interface
   - Added unit tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [uima-uimaj] reckart commented on pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

Posted by GitBox <gi...@apache.org>.
reckart commented on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620912


   @pkluegl When looking at this on, the different cases in the unit tests `assertPosition()` method are probably the most relevant ones - and maybe whether the naming of the methods makes sense. I was thinking about a scheme like `isCovering(...)` and `isCoveredBy(...)`, but then went with a less verbose `covering(...)` style to match standard Java predicate methods such as `equals(...)`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [uima-uimaj] reckart merged pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

Posted by GitBox <gi...@apache.org>.
reckart merged pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [uima-uimaj] reckart edited a comment on pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

Posted by GitBox <gi...@apache.org>.
reckart edited a comment on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620912


   @pkluegl When looking at this on, the different cases in the unit tests `assertPosition()` method are probably the most relevant ones - and maybe whether the naming of the methods makes sense. I was thinking about a scheme like `isCovering(...)` and `isCoveredBy(...)`, but then went with a less verbose `covers(...)` style to match standard Java predicate methods such as `equals(...)`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [uima-uimaj] reckart commented on pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

Posted by GitBox <gi...@apache.org>.
reckart commented on pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62#issuecomment-706620518


   @pkluegl care to review this one?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [uima-uimaj] reckart merged pull request #62: [UIMA-6151] Containment/overlap predicates for AnnotationFS

Posted by GitBox <gi...@apache.org>.
reckart merged pull request #62:
URL: https://github.com/apache/uima-uimaj/pull/62


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org