You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Adrien Grand <jp...@gmail.com> on 2019/12/12 08:55:50 UTC
New branch and feature freeze for Lucene/Solr 8.4.0
NOTICE:
Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
Please observe the normal rules:
* No new features may be committed to the branch.
* Documentation patches, build patches and serious bug fixes may be
committed to the branch. However, you should submit all patches you
want to commit to Jira first to give others the chance to review
and possibly vote against the patch. Keep in mind that it is our
main intention to keep the branch as stable as possible.
* All patches that are intended for the branch should first be committed
to the unstable branch, merged into the stable branch, and then into
the current release branch.
* Normal unstable and stable branch development may continue as usual.
However, if you plan to commit a big change to the unstable branch
while the branch feature freeze is in effect, think twice: can't the
addition wait a couple more days? Merges of bug fixes into the branch
may become more difficult.
* Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
a release candidate build.
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Hi Ishan,
I'm fine with all these changes.
On Fri, Dec 13, 2019 at 1:20 AM Ishan Chattopadhyaya <
ichattopadhyaya@gmail.com> wrote:
> Hi Adrien,
> I meant to include the following for the release branch, but it was
> already cut by the time I backported to branch_8x and I didn't realize
> it at the time. May I backport them now?
>
> SOLR-13978 Remove bloat from default configset
> SOLR-14071 Untrusted configsets shouldn't be allowed to use <lib> directive
> SOLR-14065 Deprecate Velocity
>
> I also wish to add the following deprecations into 8.4.
>
> SOLR-14067 Deprecate StatelessScriptUpdateProcessor
> SOLR-14066 Deprecate DIH
> SOLR-14070 Deprecate CloudSolrClient's ZKHost constructor
> SOLR-14072 Deprecate plugin loading using runtimelib
>
> Please let me know if that is fine by you, and I'll do this soon. I
> think it should not affect the stability of the release in any way.
> All of these deprecations are important for security purposes, besides
> making Solr more maintainable.
>
> Thanks and regards,
> Ishan
>
> On Fri, Dec 13, 2019 at 3:47 AM Andrzej Białecki <ab...@getopt.org> wrote:
> >
> > Done.
> >
> > On 12 Dec 2019, at 18:23, Adrien Grand <jp...@gmail.com> wrote:
> >
> > Thank you Andrzej. I noticed my initial suggestion for the RC date falls
> on Saturday, so I'll build on Monday instead. This will give some more CI
> cycles to the recent changes that have been merged.
> >
> > On Thu, Dec 12, 2019 at 6:14 PM Andrzej Białecki <ab...@getopt.org> wrote:
> >>
> >> Adrien,
> >> Jenkins discovered a bug in my recent fix for SOLR-13975 (see
> https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/), I’m
> testing a fix and should be able to commit it in an hour or so. I’d like to
> merge it to branch_8_4.
> >>
> >> On 12 Dec 2019, at 15:35, Adrien Grand <jp...@gmail.com> wrote:
> >>
> >> Thanks Uwe!
> >>
> >> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uw...@thetaphi.de> wrote:
> >>>
> >>> I enabled the Jenkins jobs on Policeman Jenkins.
> >>>
> >>>
> >>>
> >>> Uwe
> >>>
> >>>
> >>>
> >>> -----
> >>>
> >>> Uwe Schindler
> >>>
> >>> Achterdiek 19, D-28357 Bremen
> >>>
> >>> https://www.thetaphi.de
> >>>
> >>> eMail: uwe@thetaphi.de
> >>>
> >>>
> >>>
> >>> From: Adrien Grand <jp...@gmail.com>
> >>> Sent: Thursday, December 12, 2019 9:56 AM
> >>> To: Lucene Dev <de...@lucene.apache.org>
> >>> Subject: New branch and feature freeze for Lucene/Solr 8.4.0
> >>>
> >>>
> >>>
> >>> NOTICE:
> >>>
> >>> Branch branch_8_4 has been cut and versions updated to 8.5 on stable
> branch.
> >>>
> >>> Please observe the normal rules:
> >>>
> >>> * No new features may be committed to the branch.
> >>> * Documentation patches, build patches and serious bug fixes may be
> >>> committed to the branch. However, you should submit all patches you
> >>> want to commit to Jira first to give others the chance to review
> >>> and possibly vote against the patch. Keep in mind that it is our
> >>> main intention to keep the branch as stable as possible.
> >>> * All patches that are intended for the branch should first be
> committed
> >>> to the unstable branch, merged into the stable branch, and then into
> >>> the current release branch.
> >>> * Normal unstable and stable branch development may continue as usual.
> >>> However, if you plan to commit a big change to the unstable branch
> >>> while the branch feature freeze is in effect, think twice: can't the
> >>> addition wait a couple more days? Merges of bug fixes into the branch
> >>> may become more difficult.
> >>> * Only Jira issues with Fix version 8.4 and priority "Blocker" will
> delay
> >>> a release candidate build.
> >>>
> >>>
> >>>
> >>> --
> >>>
> >>> Adrien
> >>
> >>
> >>
> >> --
> >> Adrien
> >>
> >>
> >
> >
> > --
> > Adrien
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Hi Kevin,
If you don't mind waiting a bit, that will make things easier. Otherwise
we'd need to add the 8.4.1 version to the changelog for this change, and
this would be in the way of a new RC, would we need to do another one.
On Fri, Dec 20, 2019 at 5:24 AM Kevin Risden <kr...@apache.org> wrote:
> Adrien - there is a bug fix for Solr and TLS clientAuth -
> https://issues.apache.org/jira/browse/SOLR-14106. Based on the comments
> there don't think its required to respin 8.4.0.
>
> Is it ok to commit to branch_8_4 in case there is a need for a respin so
> it gets picked up? Otherwise I would expect it could be in a potential
> future 8.4.1 if someone volunteers as a RM.
>
> I don't want to mess up the 8.4.0 release so I'll hold off on branch_8_4
> commit until I hear. Thanks!
>
> Kevin Risden
>
>
> On Tue, Dec 17, 2019 at 10:47 AM Adrien Grand <jp...@gmail.com> wrote:
>
>> Go ahead Cassandra, I have built already, I'm now uploading the artifacts.
>>
>> On Tue, Dec 17, 2019 at 4:39 PM Cassandra Targett <ca...@gmail.com>
>> wrote:
>>
>>> I’m going to have a few commits coming in to branch_8_4 today for the
>>> Ref Guide - I’m assuming as usual it’s OK for me to go ahead but if you
>>> want me to hold for a short time while you’re building or whatever, I will.
>>> On Dec 16, 2019, 9:35 AM -0600, Adrien Grand <jp...@gmail.com>, wrote:
>>>
>>> Awesome, thanks Ishan.
>>>
>>> On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya <
>>> ichattopadhyaya@gmail.com> wrote:
>>>
>>>> Adrien, I've pushed a fix for that issue. The failure was probably due
>>>> to usual flakiness, but hopefully you won't see the exception for that
>>>> test that Dawid reported.
>>>> I don't think it should be a blocker anymore (the other problem is
>>>> that a test is trying to write data to source tree; I think that can
>>>> be solved later).
>>>>
>>>> On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
>>>> >
>>>> > Could someone look at
>>>> https://issues.apache.org/jira/browse/SOLR-14096 which Dawid just
>>>> opened? It looks to me like it should be a blocker?
>>>> >
>>>> > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com>
>>>> wrote:
>>>> >>
>>>> >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087
>>>> too.
>>>> >>
>>>> >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
>>>> ichattopadhyaya@gmail.com> wrote:
>>>> >>>
>>>> >>> Hi Adrien,
>>>> >>> I reverted one of the changes in SOLR-14087, and backported to 8.4
>>>> >>> branch. Apologies for the last moment change.
>>>> >>> If RC1 goes out without this change, no worries and we'll deal with
>>>> it later.
>>>> >>> Thanks and regards,
>>>> >>> Ishan
>>>> >>>
>>>> >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
>>>> >>> <ic...@gmail.com> wrote:
>>>> >>> >
>>>> >>> > Hi Adrien,
>>>> >>> > Let's push it to 8.5.
>>>> >>> > +1 to proceed for RC1.
>>>> >>> > Thanks,
>>>> >>> > Ishan
>>>> >>> >
>>>> >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com>
>>>> wrote:
>>>> >>> >>
>>>> >>> >> Among the various JIRAs mentioned above, it looks like only
>>>> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
>>>> let me know if there are other JIRAs that you are thinking of getting it
>>>> that have not been pushed yet, but in general I'd like to start pushing
>>>> changes to 8.5 whenever possible to avoid delaying the release too much.
>>>> >>> >>
>>>> >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
>>>> wrote:
>>>> >>> >>>
>>>> >>> >>> I plan to commit the following as well.
>>>> >>> >>> It's just a precautionery measure to avoid any future exploits
>>>> >>> >>> https://github.com/apache/lucene-solr/pull/1085
>>>> >>> >>>
>>>> >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>>>> >>> >>> <ic...@gmail.com> wrote:
>>>> >>> >>> >
>>>> >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch.
>>>> I tested
>>>> >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble
>>>> and
>>>> >>> >>> > Eduardo.
>>>> >>> >>> >
>>>> >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <
>>>> jpountz@gmail.com> wrote:
>>>> >>> >>> > >
>>>> >>> >>> > > Hi Kevin,
>>>> >>> >>> > >
>>>> >>> >>> > > I'll defer to your judgement regarding whether this is safe
>>>> to get in 8.4.
>>>> >>> >>> > >
>>>> >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <
>>>> krisden@apache.org> a écrit :
>>>> >>> >>> > >>
>>>> >>> >>> > >> Tim found SOLR-14086 which looks like a test only
>>>> dependency leaking into compile caused by SOLR-14033. I put a patch up. I
>>>> won't get to get it until later tonight or tomorrow ~24hrs from now.
>>>> >>> >>> > >>
>>>> >>> >>> > >> This causes any Solr Tika usage with 7z or a few other
>>>> compressed file types (depends if they use commons-compress) to fail due to
>>>> different classloaders being used.
>>>> >>> >>> > >>
>>>> >>> >>> > >> Kevin Risden
>>>> >>> >>> > >>
>>>> >>> >>> > >>
>>>> >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
>>>> jan.asf@cominvent.com> wrote:
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> Deprecation of DIH is ready for review
>>>> https://issues.apache.org/jira/browse/SOLR-14066
>>>> >>> >>> > >>> One code change which is a WARN log at startup, other
>>>> changes are documentation.
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than
>>>> later in 8.x. Your call Adrien.
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> Jan
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <
>>>> jpountz@gmail.com>:
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> Let's get that one in as well, thanks Yonik.
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <
>>>> yseeley@gmail.com> wrote:
>>>> >>> >>> > >>>>
>>>> >>> >>> > >>>> Heads up on
>>>> https://issues.apache.org/jira/browse/SOLR-14079
>>>> >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix
>>>> does not work.) . The fix is super simple and very low risk since it's
>>>> encapsulated within the block only used when splitByPrefix=true.
>>>> >>> >>> > >>>>
>>>> >>> >>> > >>>> -Yonik
>>>> >>> >>> > >>>>
>>>> >>> >>> > >>>
>>>> >>> >>> > >>>
>>>> >>> >>> > >>> --
>>>> >>> >>> > >>> Adrien
>>>> >>> >>> > >>>
>>>> >>> >>> > >>>
>>>> >>> >>> >
>>>> >>> >>> >
>>>> ---------------------------------------------------------------------
>>>> >>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> >>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
>>>> >>> >>> >
>>>> >>> >>>
>>>> >>> >>>
>>>> >>> >>> --
>>>> >>> >>> -----------------------------------------------------
>>>> >>> >>> Noble Paul
>>>> >>> >>>
>>>> >>> >>>
>>>> ---------------------------------------------------------------------
>>>> >>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> >>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>> >>> >>>
>>>> >>> >>
>>>> >>> >>
>>>> >>> >> --
>>>> >>> >> Adrien
>>>> >>>
>>>> >>>
>>>> ---------------------------------------------------------------------
>>>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>> >>>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Adrien
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Adrien
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>> --
>>> Adrien
>>>
>>>
>>
>> --
>> Adrien
>>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Kevin Risden <kr...@apache.org>.
Adrien - there is a bug fix for Solr and TLS clientAuth -
https://issues.apache.org/jira/browse/SOLR-14106. Based on the comments
there don't think its required to respin 8.4.0.
Is it ok to commit to branch_8_4 in case there is a need for a respin so it
gets picked up? Otherwise I would expect it could be in a potential future
8.4.1 if someone volunteers as a RM.
I don't want to mess up the 8.4.0 release so I'll hold off on branch_8_4
commit until I hear. Thanks!
Kevin Risden
On Tue, Dec 17, 2019 at 10:47 AM Adrien Grand <jp...@gmail.com> wrote:
> Go ahead Cassandra, I have built already, I'm now uploading the artifacts.
>
> On Tue, Dec 17, 2019 at 4:39 PM Cassandra Targett <ca...@gmail.com>
> wrote:
>
>> I’m going to have a few commits coming in to branch_8_4 today for the Ref
>> Guide - I’m assuming as usual it’s OK for me to go ahead but if you want me
>> to hold for a short time while you’re building or whatever, I will.
>> On Dec 16, 2019, 9:35 AM -0600, Adrien Grand <jp...@gmail.com>, wrote:
>>
>> Awesome, thanks Ishan.
>>
>> On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya <
>> ichattopadhyaya@gmail.com> wrote:
>>
>>> Adrien, I've pushed a fix for that issue. The failure was probably due
>>> to usual flakiness, but hopefully you won't see the exception for that
>>> test that Dawid reported.
>>> I don't think it should be a blocker anymore (the other problem is
>>> that a test is trying to write data to source tree; I think that can
>>> be solved later).
>>>
>>> On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
>>> >
>>> > Could someone look at https://issues.apache.org/jira/browse/SOLR-14096
>>> which Dawid just opened? It looks to me like it should be a blocker?
>>> >
>>> > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com>
>>> wrote:
>>> >>
>>> >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087
>>> too.
>>> >>
>>> >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
>>> ichattopadhyaya@gmail.com> wrote:
>>> >>>
>>> >>> Hi Adrien,
>>> >>> I reverted one of the changes in SOLR-14087, and backported to 8.4
>>> >>> branch. Apologies for the last moment change.
>>> >>> If RC1 goes out without this change, no worries and we'll deal with
>>> it later.
>>> >>> Thanks and regards,
>>> >>> Ishan
>>> >>>
>>> >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
>>> >>> <ic...@gmail.com> wrote:
>>> >>> >
>>> >>> > Hi Adrien,
>>> >>> > Let's push it to 8.5.
>>> >>> > +1 to proceed for RC1.
>>> >>> > Thanks,
>>> >>> > Ishan
>>> >>> >
>>> >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com>
>>> wrote:
>>> >>> >>
>>> >>> >> Among the various JIRAs mentioned above, it looks like only
>>> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
>>> let me know if there are other JIRAs that you are thinking of getting it
>>> that have not been pushed yet, but in general I'd like to start pushing
>>> changes to 8.5 whenever possible to avoid delaying the release too much.
>>> >>> >>
>>> >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
>>> wrote:
>>> >>> >>>
>>> >>> >>> I plan to commit the following as well.
>>> >>> >>> It's just a precautionery measure to avoid any future exploits
>>> >>> >>> https://github.com/apache/lucene-solr/pull/1085
>>> >>> >>>
>>> >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>>> >>> >>> <ic...@gmail.com> wrote:
>>> >>> >>> >
>>> >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch.
>>> I tested
>>> >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble
>>> and
>>> >>> >>> > Eduardo.
>>> >>> >>> >
>>> >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <
>>> jpountz@gmail.com> wrote:
>>> >>> >>> > >
>>> >>> >>> > > Hi Kevin,
>>> >>> >>> > >
>>> >>> >>> > > I'll defer to your judgement regarding whether this is safe
>>> to get in 8.4.
>>> >>> >>> > >
>>> >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <
>>> krisden@apache.org> a écrit :
>>> >>> >>> > >>
>>> >>> >>> > >> Tim found SOLR-14086 which looks like a test only
>>> dependency leaking into compile caused by SOLR-14033. I put a patch up. I
>>> won't get to get it until later tonight or tomorrow ~24hrs from now.
>>> >>> >>> > >>
>>> >>> >>> > >> This causes any Solr Tika usage with 7z or a few other
>>> compressed file types (depends if they use commons-compress) to fail due to
>>> different classloaders being used.
>>> >>> >>> > >>
>>> >>> >>> > >> Kevin Risden
>>> >>> >>> > >>
>>> >>> >>> > >>
>>> >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
>>> jan.asf@cominvent.com> wrote:
>>> >>> >>> > >>>
>>> >>> >>> > >>> Deprecation of DIH is ready for review
>>> https://issues.apache.org/jira/browse/SOLR-14066
>>> >>> >>> > >>> One code change which is a WARN log at startup, other
>>> changes are documentation.
>>> >>> >>> > >>>
>>> >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than
>>> later in 8.x. Your call Adrien.
>>> >>> >>> > >>>
>>> >>> >>> > >>> Jan
>>> >>> >>> > >>>
>>> >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <
>>> jpountz@gmail.com>:
>>> >>> >>> > >>>
>>> >>> >>> > >>> Let's get that one in as well, thanks Yonik.
>>> >>> >>> > >>>
>>> >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <
>>> yseeley@gmail.com> wrote:
>>> >>> >>> > >>>>
>>> >>> >>> > >>>> Heads up on
>>> https://issues.apache.org/jira/browse/SOLR-14079
>>> >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix
>>> does not work.) . The fix is super simple and very low risk since it's
>>> encapsulated within the block only used when splitByPrefix=true.
>>> >>> >>> > >>>>
>>> >>> >>> > >>>> -Yonik
>>> >>> >>> > >>>>
>>> >>> >>> > >>>
>>> >>> >>> > >>>
>>> >>> >>> > >>> --
>>> >>> >>> > >>> Adrien
>>> >>> >>> > >>>
>>> >>> >>> > >>>
>>> >>> >>> >
>>> >>> >>> >
>>> ---------------------------------------------------------------------
>>> >>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>> >>> >
>>> >>> >>>
>>> >>> >>>
>>> >>> >>> --
>>> >>> >>> -----------------------------------------------------
>>> >>> >>> Noble Paul
>>> >>> >>>
>>> >>> >>>
>>> ---------------------------------------------------------------------
>>> >>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>> >>>
>>> >>> >>
>>> >>> >>
>>> >>> >> --
>>> >>> >> Adrien
>>> >>>
>>> >>> ---------------------------------------------------------------------
>>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>>
>>> >>
>>> >>
>>> >> --
>>> >> Adrien
>>> >
>>> >
>>> >
>>> > --
>>> > Adrien
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
>>
>> --
>> Adrien
>>
>>
>
> --
> Adrien
>
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Go ahead Cassandra, I have built already, I'm now uploading the artifacts.
On Tue, Dec 17, 2019 at 4:39 PM Cassandra Targett <ca...@gmail.com>
wrote:
> I’m going to have a few commits coming in to branch_8_4 today for the Ref
> Guide - I’m assuming as usual it’s OK for me to go ahead but if you want me
> to hold for a short time while you’re building or whatever, I will.
> On Dec 16, 2019, 9:35 AM -0600, Adrien Grand <jp...@gmail.com>, wrote:
>
> Awesome, thanks Ishan.
>
> On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com> wrote:
>
>> Adrien, I've pushed a fix for that issue. The failure was probably due
>> to usual flakiness, but hopefully you won't see the exception for that
>> test that Dawid reported.
>> I don't think it should be a blocker anymore (the other problem is
>> that a test is trying to write data to source tree; I think that can
>> be solved later).
>>
>> On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
>> >
>> > Could someone look at https://issues.apache.org/jira/browse/SOLR-14096
>> which Dawid just opened? It looks to me like it should be a blocker?
>> >
>> > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com> wrote:
>> >>
>> >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087
>> too.
>> >>
>> >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
>> ichattopadhyaya@gmail.com> wrote:
>> >>>
>> >>> Hi Adrien,
>> >>> I reverted one of the changes in SOLR-14087, and backported to 8.4
>> >>> branch. Apologies for the last moment change.
>> >>> If RC1 goes out without this change, no worries and we'll deal with
>> it later.
>> >>> Thanks and regards,
>> >>> Ishan
>> >>>
>> >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
>> >>> <ic...@gmail.com> wrote:
>> >>> >
>> >>> > Hi Adrien,
>> >>> > Let's push it to 8.5.
>> >>> > +1 to proceed for RC1.
>> >>> > Thanks,
>> >>> > Ishan
>> >>> >
>> >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com>
>> wrote:
>> >>> >>
>> >>> >> Among the various JIRAs mentioned above, it looks like only
>> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
>> let me know if there are other JIRAs that you are thinking of getting it
>> that have not been pushed yet, but in general I'd like to start pushing
>> changes to 8.5 whenever possible to avoid delaying the release too much.
>> >>> >>
>> >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
>> wrote:
>> >>> >>>
>> >>> >>> I plan to commit the following as well.
>> >>> >>> It's just a precautionery measure to avoid any future exploits
>> >>> >>> https://github.com/apache/lucene-solr/pull/1085
>> >>> >>>
>> >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>> >>> >>> <ic...@gmail.com> wrote:
>> >>> >>> >
>> >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I
>> tested
>> >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble
>> and
>> >>> >>> > Eduardo.
>> >>> >>> >
>> >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com>
>> wrote:
>> >>> >>> > >
>> >>> >>> > > Hi Kevin,
>> >>> >>> > >
>> >>> >>> > > I'll defer to your judgement regarding whether this is safe
>> to get in 8.4.
>> >>> >>> > >
>> >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <
>> krisden@apache.org> a écrit :
>> >>> >>> > >>
>> >>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency
>> leaking into compile caused by SOLR-14033. I put a patch up. I won't get to
>> get it until later tonight or tomorrow ~24hrs from now.
>> >>> >>> > >>
>> >>> >>> > >> This causes any Solr Tika usage with 7z or a few other
>> compressed file types (depends if they use commons-compress) to fail due to
>> different classloaders being used.
>> >>> >>> > >>
>> >>> >>> > >> Kevin Risden
>> >>> >>> > >>
>> >>> >>> > >>
>> >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
>> jan.asf@cominvent.com> wrote:
>> >>> >>> > >>>
>> >>> >>> > >>> Deprecation of DIH is ready for review
>> https://issues.apache.org/jira/browse/SOLR-14066
>> >>> >>> > >>> One code change which is a WARN log at startup, other
>> changes are documentation.
>> >>> >>> > >>>
>> >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than
>> later in 8.x. Your call Adrien.
>> >>> >>> > >>>
>> >>> >>> > >>> Jan
>> >>> >>> > >>>
>> >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <
>> jpountz@gmail.com>:
>> >>> >>> > >>>
>> >>> >>> > >>> Let's get that one in as well, thanks Yonik.
>> >>> >>> > >>>
>> >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <
>> yseeley@gmail.com> wrote:
>> >>> >>> > >>>>
>> >>> >>> > >>>> Heads up on
>> https://issues.apache.org/jira/browse/SOLR-14079
>> >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix
>> does not work.) . The fix is super simple and very low risk since it's
>> encapsulated within the block only used when splitByPrefix=true.
>> >>> >>> > >>>>
>> >>> >>> > >>>> -Yonik
>> >>> >>> > >>>>
>> >>> >>> > >>>
>> >>> >>> > >>>
>> >>> >>> > >>> --
>> >>> >>> > >>> Adrien
>> >>> >>> > >>>
>> >>> >>> > >>>
>> >>> >>> >
>> >>> >>> >
>> ---------------------------------------------------------------------
>> >>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
>> >>> >>> >
>> >>> >>>
>> >>> >>>
>> >>> >>> --
>> >>> >>> -----------------------------------------------------
>> >>> >>> Noble Paul
>> >>> >>>
>> >>> >>>
>> ---------------------------------------------------------------------
>> >>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>> >>>
>> >>> >>
>> >>> >>
>> >>> >> --
>> >>> >> Adrien
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>>
>> >>
>> >>
>> >> --
>> >> Adrien
>> >
>> >
>> >
>> > --
>> > Adrien
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>
> --
> Adrien
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Cassandra Targett <ca...@gmail.com>.
I’m going to have a few commits coming in to branch_8_4 today for the Ref Guide - I’m assuming as usual it’s OK for me to go ahead but if you want me to hold for a short time while you’re building or whatever, I will.
On Dec 16, 2019, 9:35 AM -0600, Adrien Grand <jp...@gmail.com>, wrote:
> Awesome, thanks Ishan.
>
> > On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya <ic...@gmail.com> wrote:
> > > Adrien, I've pushed a fix for that issue. The failure was probably due
> > > to usual flakiness, but hopefully you won't see the exception for that
> > > test that Dawid reported.
> > > I don't think it should be a blocker anymore (the other problem is
> > > that a test is trying to write data to source tree; I think that can
> > > be solved later).
> > >
> > > On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
> > > >
> > > > Could someone look at https://issues.apache.org/jira/browse/SOLR-14096 which Dawid just opened? It looks to me like it should be a blocker?
> > > >
> > > > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com> wrote:
> > > >>
> > > >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too.
> > > >>
> > > >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <ic...@gmail.com> wrote:
> > > >>>
> > > >>> Hi Adrien,
> > > >>> I reverted one of the changes in SOLR-14087, and backported to 8.4
> > > >>> branch. Apologies for the last moment change.
> > > >>> If RC1 goes out without this change, no worries and we'll deal with it later.
> > > >>> Thanks and regards,
> > > >>> Ishan
> > > >>>
> > > >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
> > > >>> <ic...@gmail.com> wrote:
> > > >>> >
> > > >>> > Hi Adrien,
> > > >>> > Let's push it to 8.5.
> > > >>> > +1 to proceed for RC1.
> > > >>> > Thanks,
> > > >>> > Ishan
> > > >>> >
> > > >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
> > > >>> >>
> > > >>> >> Among the various JIRAs mentioned above, it looks like only https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please let me know if there are other JIRAs that you are thinking of getting it that have not been pushed yet, but in general I'd like to start pushing changes to 8.5 whenever possible to avoid delaying the release too much.
> > > >>> >>
> > > >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com> wrote:
> > > >>> >>>
> > > >>> >>> I plan to commit the following as well.
> > > >>> >>> It's just a precautionery measure to avoid any future exploits
> > > >>> >>> https://github.com/apache/lucene-solr/pull/1085
> > > >>> >>>
> > > >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
> > > >>> >>> <ic...@gmail.com> wrote:
> > > >>> >>> >
> > > >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I tested
> > > >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and
> > > >>> >>> > Eduardo.
> > > >>> >>> >
> > > >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
> > > >>> >>> > >
> > > >>> >>> > > Hi Kevin,
> > > >>> >>> > >
> > > >>> >>> > > I'll defer to your judgement regarding whether this is safe to get in 8.4.
> > > >>> >>> > >
> > > >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
> > > >>> >>> > >>
> > > >>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now.
> > > >>> >>> > >>
> > > >>> >>> > >> This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use commons-compress) to fail due to different classloaders being used.
> > > >>> >>> > >>
> > > >>> >>> > >> Kevin Risden
> > > >>> >>> > >>
> > > >>> >>> > >>
> > > >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
> > > >>> >>> > >>>
> > > >>> >>> > >>> Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066
> > > >>> >>> > >>> One code change which is a WARN log at startup, other changes are documentation.
> > > >>> >>> > >>>
> > > >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
> > > >>> >>> > >>>
> > > >>> >>> > >>> Jan
> > > >>> >>> > >>>
> > > >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
> > > >>> >>> > >>>
> > > >>> >>> > >>> Let's get that one in as well, thanks Yonik.
> > > >>> >>> > >>>
> > > >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
> > > >>> >>> > >>>>
> > > >>> >>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
> > > >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
> > > >>> >>> > >>>>
> > > >>> >>> > >>>> -Yonik
> > > >>> >>> > >>>>
> > > >>> >>> > >>>
> > > >>> >>> > >>>
> > > >>> >>> > >>> --
> > > >>> >>> > >>> Adrien
> > > >>> >>> > >>>
> > > >>> >>> > >>>
> > > >>> >>> >
> > > >>> >>> > ---------------------------------------------------------------------
> > > >>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > >>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
> > > >>> >>> >
> > > >>> >>>
> > > >>> >>>
> > > >>> >>> --
> > > >>> >>> -----------------------------------------------------
> > > >>> >>> Noble Paul
> > > >>> >>>
> > > >>> >>> ---------------------------------------------------------------------
> > > >>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > >>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
> > > >>> >>>
> > > >>> >>
> > > >>> >>
> > > >>> >> --
> > > >>> >> Adrien
> > > >>>
> > > >>> ---------------------------------------------------------------------
> > > >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > >>> For additional commands, e-mail: dev-help@lucene.apache.org
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Adrien
> > > >
> > > >
> > > >
> > > > --
> > > > Adrien
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
>
>
> --
> Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Awesome, thanks Ishan.
On Mon, Dec 16, 2019 at 4:14 PM Ishan Chattopadhyaya <
ichattopadhyaya@gmail.com> wrote:
> Adrien, I've pushed a fix for that issue. The failure was probably due
> to usual flakiness, but hopefully you won't see the exception for that
> test that Dawid reported.
> I don't think it should be a blocker anymore (the other problem is
> that a test is trying to write data to source tree; I think that can
> be solved later).
>
> On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
> >
> > Could someone look at https://issues.apache.org/jira/browse/SOLR-14096
> which Dawid just opened? It looks to me like it should be a blocker?
> >
> > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com> wrote:
> >>
> >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too.
> >>
> >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com> wrote:
> >>>
> >>> Hi Adrien,
> >>> I reverted one of the changes in SOLR-14087, and backported to 8.4
> >>> branch. Apologies for the last moment change.
> >>> If RC1 goes out without this change, no worries and we'll deal with it
> later.
> >>> Thanks and regards,
> >>> Ishan
> >>>
> >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
> >>> <ic...@gmail.com> wrote:
> >>> >
> >>> > Hi Adrien,
> >>> > Let's push it to 8.5.
> >>> > +1 to proceed for RC1.
> >>> > Thanks,
> >>> > Ishan
> >>> >
> >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com>
> wrote:
> >>> >>
> >>> >> Among the various JIRAs mentioned above, it looks like only
> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
> let me know if there are other JIRAs that you are thinking of getting it
> that have not been pushed yet, but in general I'd like to start pushing
> changes to 8.5 whenever possible to avoid delaying the release too much.
> >>> >>
> >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
> wrote:
> >>> >>>
> >>> >>> I plan to commit the following as well.
> >>> >>> It's just a precautionery measure to avoid any future exploits
> >>> >>> https://github.com/apache/lucene-solr/pull/1085
> >>> >>>
> >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
> >>> >>> <ic...@gmail.com> wrote:
> >>> >>> >
> >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I
> tested
> >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and
> >>> >>> > Eduardo.
> >>> >>> >
> >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com>
> wrote:
> >>> >>> > >
> >>> >>> > > Hi Kevin,
> >>> >>> > >
> >>> >>> > > I'll defer to your judgement regarding whether this is safe to
> get in 8.4.
> >>> >>> > >
> >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org>
> a écrit :
> >>> >>> > >>
> >>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency
> leaking into compile caused by SOLR-14033. I put a patch up. I won't get to
> get it until later tonight or tomorrow ~24hrs from now.
> >>> >>> > >>
> >>> >>> > >> This causes any Solr Tika usage with 7z or a few other
> compressed file types (depends if they use commons-compress) to fail due to
> different classloaders being used.
> >>> >>> > >>
> >>> >>> > >> Kevin Risden
> >>> >>> > >>
> >>> >>> > >>
> >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
> jan.asf@cominvent.com> wrote:
> >>> >>> > >>>
> >>> >>> > >>> Deprecation of DIH is ready for review
> https://issues.apache.org/jira/browse/SOLR-14066
> >>> >>> > >>> One code change which is a WARN log at startup, other
> changes are documentation.
> >>> >>> > >>>
> >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than later
> in 8.x. Your call Adrien.
> >>> >>> > >>>
> >>> >>> > >>> Jan
> >>> >>> > >>>
> >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <
> jpountz@gmail.com>:
> >>> >>> > >>>
> >>> >>> > >>> Let's get that one in as well, thanks Yonik.
> >>> >>> > >>>
> >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <
> yseeley@gmail.com> wrote:
> >>> >>> > >>>>
> >>> >>> > >>>> Heads up on
> https://issues.apache.org/jira/browse/SOLR-14079
> >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix
> does not work.) . The fix is super simple and very low risk since it's
> encapsulated within the block only used when splitByPrefix=true.
> >>> >>> > >>>>
> >>> >>> > >>>> -Yonik
> >>> >>> > >>>>
> >>> >>> > >>>
> >>> >>> > >>>
> >>> >>> > >>> --
> >>> >>> > >>> Adrien
> >>> >>> > >>>
> >>> >>> > >>>
> >>> >>> >
> >>> >>> >
> ---------------------------------------------------------------------
> >>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
> >>> >>> >
> >>> >>>
> >>> >>>
> >>> >>> --
> >>> >>> -----------------------------------------------------
> >>> >>> Noble Paul
> >>> >>>
> >>> >>>
> ---------------------------------------------------------------------
> >>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
> >>> >>>
> >>> >>
> >>> >>
> >>> >> --
> >>> >> Adrien
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >>> For additional commands, e-mail: dev-help@lucene.apache.org
> >>>
> >>
> >>
> >> --
> >> Adrien
> >
> >
> >
> > --
> > Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Adrien, I've pushed a fix for that issue. The failure was probably due
to usual flakiness, but hopefully you won't see the exception for that
test that Dawid reported.
I don't think it should be a blocker anymore (the other problem is
that a test is trying to write data to source tree; I think that can
be solved later).
On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <jp...@gmail.com> wrote:
>
> Could someone look at https://issues.apache.org/jira/browse/SOLR-14096 which Dawid just opened? It looks to me like it should be a blocker?
>
> On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com> wrote:
>>
>> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too.
>>
>> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <ic...@gmail.com> wrote:
>>>
>>> Hi Adrien,
>>> I reverted one of the changes in SOLR-14087, and backported to 8.4
>>> branch. Apologies for the last moment change.
>>> If RC1 goes out without this change, no worries and we'll deal with it later.
>>> Thanks and regards,
>>> Ishan
>>>
>>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
>>> <ic...@gmail.com> wrote:
>>> >
>>> > Hi Adrien,
>>> > Let's push it to 8.5.
>>> > +1 to proceed for RC1.
>>> > Thanks,
>>> > Ishan
>>> >
>>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
>>> >>
>>> >> Among the various JIRAs mentioned above, it looks like only https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please let me know if there are other JIRAs that you are thinking of getting it that have not been pushed yet, but in general I'd like to start pushing changes to 8.5 whenever possible to avoid delaying the release too much.
>>> >>
>>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com> wrote:
>>> >>>
>>> >>> I plan to commit the following as well.
>>> >>> It's just a precautionery measure to avoid any future exploits
>>> >>> https://github.com/apache/lucene-solr/pull/1085
>>> >>>
>>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>>> >>> <ic...@gmail.com> wrote:
>>> >>> >
>>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I tested
>>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and
>>> >>> > Eduardo.
>>> >>> >
>>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
>>> >>> > >
>>> >>> > > Hi Kevin,
>>> >>> > >
>>> >>> > > I'll defer to your judgement regarding whether this is safe to get in 8.4.
>>> >>> > >
>>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
>>> >>> > >>
>>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now.
>>> >>> > >>
>>> >>> > >> This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use commons-compress) to fail due to different classloaders being used.
>>> >>> > >>
>>> >>> > >> Kevin Risden
>>> >>> > >>
>>> >>> > >>
>>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
>>> >>> > >>>
>>> >>> > >>> Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066
>>> >>> > >>> One code change which is a WARN log at startup, other changes are documentation.
>>> >>> > >>>
>>> >>> > >>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
>>> >>> > >>>
>>> >>> > >>> Jan
>>> >>> > >>>
>>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>>> >>> > >>>
>>> >>> > >>> Let's get that one in as well, thanks Yonik.
>>> >>> > >>>
>>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>>> >>> > >>>>
>>> >>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
>>> >>> > >>>>
>>> >>> > >>>> -Yonik
>>> >>> > >>>>
>>> >>> > >>>
>>> >>> > >>>
>>> >>> > >>> --
>>> >>> > >>> Adrien
>>> >>> > >>>
>>> >>> > >>>
>>> >>> >
>>> >>> > ---------------------------------------------------------------------
>>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>> >
>>> >>>
>>> >>>
>>> >>> --
>>> >>> -----------------------------------------------------
>>> >>> Noble Paul
>>> >>>
>>> >>> ---------------------------------------------------------------------
>>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>>
>>> >>
>>> >>
>>> >> --
>>> >> Adrien
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>>
>> --
>> Adrien
>
>
>
> --
> Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Could someone look at https://issues.apache.org/jira/browse/SOLR-14096 which
Dawid just opened? It looks to me like it should be a blocker?
On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <jp...@gmail.com> wrote:
> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too.
>
> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
> ichattopadhyaya@gmail.com> wrote:
>
>> Hi Adrien,
>> I reverted one of the changes in SOLR-14087, and backported to 8.4
>> branch. Apologies for the last moment change.
>> If RC1 goes out without this change, no worries and we'll deal with it
>> later.
>> Thanks and regards,
>> Ishan
>>
>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
>> <ic...@gmail.com> wrote:
>> >
>> > Hi Adrien,
>> > Let's push it to 8.5.
>> > +1 to proceed for RC1.
>> > Thanks,
>> > Ishan
>> >
>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
>> >>
>> >> Among the various JIRAs mentioned above, it looks like only
>> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
>> let me know if there are other JIRAs that you are thinking of getting it
>> that have not been pushed yet, but in general I'd like to start pushing
>> changes to 8.5 whenever possible to avoid delaying the release too much.
>> >>
>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
>> wrote:
>> >>>
>> >>> I plan to commit the following as well.
>> >>> It's just a precautionery measure to avoid any future exploits
>> >>> https://github.com/apache/lucene-solr/pull/1085
>> >>>
>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>> >>> <ic...@gmail.com> wrote:
>> >>> >
>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I
>> tested
>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and
>> >>> > Eduardo.
>> >>> >
>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com>
>> wrote:
>> >>> > >
>> >>> > > Hi Kevin,
>> >>> > >
>> >>> > > I'll defer to your judgement regarding whether this is safe to
>> get in 8.4.
>> >>> > >
>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org>
>> a écrit :
>> >>> > >>
>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency
>> leaking into compile caused by SOLR-14033. I put a patch up. I won't get to
>> get it until later tonight or tomorrow ~24hrs from now.
>> >>> > >>
>> >>> > >> This causes any Solr Tika usage with 7z or a few other
>> compressed file types (depends if they use commons-compress) to fail due to
>> different classloaders being used.
>> >>> > >>
>> >>> > >> Kevin Risden
>> >>> > >>
>> >>> > >>
>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
>> jan.asf@cominvent.com> wrote:
>> >>> > >>>
>> >>> > >>> Deprecation of DIH is ready for review
>> https://issues.apache.org/jira/browse/SOLR-14066
>> >>> > >>> One code change which is a WARN log at startup, other changes
>> are documentation.
>> >>> > >>>
>> >>> > >>> Low risk and we’d like to deprecate sooner rather than later in
>> 8.x. Your call Adrien.
>> >>> > >>>
>> >>> > >>> Jan
>> >>> > >>>
>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>> >>> > >>>
>> >>> > >>> Let's get that one in as well, thanks Yonik.
>> >>> > >>>
>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com>
>> wrote:
>> >>> > >>>>
>> >>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does
>> not work.) . The fix is super simple and very low risk since it's
>> encapsulated within the block only used when splitByPrefix=true.
>> >>> > >>>>
>> >>> > >>>> -Yonik
>> >>> > >>>>
>> >>> > >>>
>> >>> > >>>
>> >>> > >>> --
>> >>> > >>> Adrien
>> >>> > >>>
>> >>> > >>>
>> >>> >
>> >>> >
>> ---------------------------------------------------------------------
>> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
>> >>> >
>> >>>
>> >>>
>> >>> --
>> >>> -----------------------------------------------------
>> >>> Noble Paul
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >>> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>>
>> >>
>> >>
>> >> --
>> >> Adrien
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>
> --
> Adrien
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too.
On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya <
ichattopadhyaya@gmail.com> wrote:
> Hi Adrien,
> I reverted one of the changes in SOLR-14087, and backported to 8.4
> branch. Apologies for the last moment change.
> If RC1 goes out without this change, no worries and we'll deal with it
> later.
> Thanks and regards,
> Ishan
>
> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
> <ic...@gmail.com> wrote:
> >
> > Hi Adrien,
> > Let's push it to 8.5.
> > +1 to proceed for RC1.
> > Thanks,
> > Ishan
> >
> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
> >>
> >> Among the various JIRAs mentioned above, it looks like only
> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
> let me know if there are other JIRAs that you are thinking of getting it
> that have not been pushed yet, but in general I'd like to start pushing
> changes to 8.5 whenever possible to avoid delaying the release too much.
> >>
> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com>
> wrote:
> >>>
> >>> I plan to commit the following as well.
> >>> It's just a precautionery measure to avoid any future exploits
> >>> https://github.com/apache/lucene-solr/pull/1085
> >>>
> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
> >>> <ic...@gmail.com> wrote:
> >>> >
> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I
> tested
> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and
> >>> > Eduardo.
> >>> >
> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com>
> wrote:
> >>> > >
> >>> > > Hi Kevin,
> >>> > >
> >>> > > I'll defer to your judgement regarding whether this is safe to get
> in 8.4.
> >>> > >
> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a
> écrit :
> >>> > >>
> >>> > >> Tim found SOLR-14086 which looks like a test only dependency
> leaking into compile caused by SOLR-14033. I put a patch up. I won't get to
> get it until later tonight or tomorrow ~24hrs from now.
> >>> > >>
> >>> > >> This causes any Solr Tika usage with 7z or a few other compressed
> file types (depends if they use commons-compress) to fail due to different
> classloaders being used.
> >>> > >>
> >>> > >> Kevin Risden
> >>> > >>
> >>> > >>
> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <
> jan.asf@cominvent.com> wrote:
> >>> > >>>
> >>> > >>> Deprecation of DIH is ready for review
> https://issues.apache.org/jira/browse/SOLR-14066
> >>> > >>> One code change which is a WARN log at startup, other changes
> are documentation.
> >>> > >>>
> >>> > >>> Low risk and we’d like to deprecate sooner rather than later in
> 8.x. Your call Adrien.
> >>> > >>>
> >>> > >>> Jan
> >>> > >>>
> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
> >>> > >>>
> >>> > >>> Let's get that one in as well, thanks Yonik.
> >>> > >>>
> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com>
> wrote:
> >>> > >>>>
> >>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does
> not work.) . The fix is super simple and very low risk since it's
> encapsulated within the block only used when splitByPrefix=true.
> >>> > >>>>
> >>> > >>>> -Yonik
> >>> > >>>>
> >>> > >>>
> >>> > >>>
> >>> > >>> --
> >>> > >>> Adrien
> >>> > >>>
> >>> > >>>
> >>> >
> >>> > ---------------------------------------------------------------------
> >>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >>> > For additional commands, e-mail: dev-help@lucene.apache.org
> >>> >
> >>>
> >>>
> >>> --
> >>> -----------------------------------------------------
> >>> Noble Paul
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >>> For additional commands, e-mail: dev-help@lucene.apache.org
> >>>
> >>
> >>
> >> --
> >> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Hi Adrien,
I reverted one of the changes in SOLR-14087, and backported to 8.4
branch. Apologies for the last moment change.
If RC1 goes out without this change, no worries and we'll deal with it later.
Thanks and regards,
Ishan
On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya
<ic...@gmail.com> wrote:
>
> Hi Adrien,
> Let's push it to 8.5.
> +1 to proceed for RC1.
> Thanks,
> Ishan
>
> On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
>>
>> Among the various JIRAs mentioned above, it looks like only https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please let me know if there are other JIRAs that you are thinking of getting it that have not been pushed yet, but in general I'd like to start pushing changes to 8.5 whenever possible to avoid delaying the release too much.
>>
>> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com> wrote:
>>>
>>> I plan to commit the following as well.
>>> It's just a precautionery measure to avoid any future exploits
>>> https://github.com/apache/lucene-solr/pull/1085
>>>
>>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>>> <ic...@gmail.com> wrote:
>>> >
>>> > I've added a few critical fixes for SOLR-13662 to the branch. I tested
>>> > them thoroughly and got reviews for the fixes from Jan, Noble and
>>> > Eduardo.
>>> >
>>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
>>> > >
>>> > > Hi Kevin,
>>> > >
>>> > > I'll defer to your judgement regarding whether this is safe to get in 8.4.
>>> > >
>>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
>>> > >>
>>> > >> Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now.
>>> > >>
>>> > >> This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use commons-compress) to fail due to different classloaders being used.
>>> > >>
>>> > >> Kevin Risden
>>> > >>
>>> > >>
>>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
>>> > >>>
>>> > >>> Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066
>>> > >>> One code change which is a WARN log at startup, other changes are documentation.
>>> > >>>
>>> > >>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
>>> > >>>
>>> > >>> Jan
>>> > >>>
>>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>>> > >>>
>>> > >>> Let's get that one in as well, thanks Yonik.
>>> > >>>
>>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>>> > >>>>
>>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
>>> > >>>>
>>> > >>>> -Yonik
>>> > >>>>
>>> > >>>
>>> > >>>
>>> > >>> --
>>> > >>> Adrien
>>> > >>>
>>> > >>>
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> > For additional commands, e-mail: dev-help@lucene.apache.org
>>> >
>>>
>>>
>>> --
>>> -----------------------------------------------------
>>> Noble Paul
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>>
>> --
>> Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Hi Adrien,
Let's push it to 8.5.
+1 to proceed for RC1.
Thanks,
Ishan
On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <jp...@gmail.com> wrote:
> Among the various JIRAs mentioned above, it looks like only
> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please
> let me know if there are other JIRAs that you are thinking of getting it
> that have not been pushed yet, but in general I'd like to start pushing
> changes to 8.5 whenever possible to avoid delaying the release too much.
>
> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com> wrote:
>
>> I plan to commit the following as well.
>> It's just a precautionery measure to avoid any future exploits
>> https://github.com/apache/lucene-solr/pull/1085
>>
>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
>> <ic...@gmail.com> wrote:
>> >
>> > I've added a few critical fixes for SOLR-13662 to the branch. I tested
>> > them thoroughly and got reviews for the fixes from Jan, Noble and
>> > Eduardo.
>> >
>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
>> > >
>> > > Hi Kevin,
>> > >
>> > > I'll defer to your judgement regarding whether this is safe to get in
>> 8.4.
>> > >
>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a
>> écrit :
>> > >>
>> > >> Tim found SOLR-14086 which looks like a test only dependency leaking
>> into compile caused by SOLR-14033. I put a patch up. I won't get to get it
>> until later tonight or tomorrow ~24hrs from now.
>> > >>
>> > >> This causes any Solr Tika usage with 7z or a few other compressed
>> file types (depends if they use commons-compress) to fail due to different
>> classloaders being used.
>> > >>
>> > >> Kevin Risden
>> > >>
>> > >>
>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com>
>> wrote:
>> > >>>
>> > >>> Deprecation of DIH is ready for review
>> https://issues.apache.org/jira/browse/SOLR-14066
>> > >>> One code change which is a WARN log at startup, other changes are
>> documentation.
>> > >>>
>> > >>> Low risk and we’d like to deprecate sooner rather than later in
>> 8.x. Your call Adrien.
>> > >>>
>> > >>> Jan
>> > >>>
>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>> > >>>
>> > >>> Let's get that one in as well, thanks Yonik.
>> > >>>
>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com>
>> wrote:
>> > >>>>
>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not
>> work.) . The fix is super simple and very low risk since it's encapsulated
>> within the block only used when splitByPrefix=true.
>> > >>>>
>> > >>>> -Yonik
>> > >>>>
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Adrien
>> > >>>
>> > >>>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> > For additional commands, e-mail: dev-help@lucene.apache.org
>> >
>>
>>
>> --
>> -----------------------------------------------------
>> Noble Paul
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>
> --
> Adrien
>
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Among the various JIRAs mentioned above, it looks like only
https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please let
me know if there are other JIRAs that you are thinking of getting it that
have not been pushed yet, but in general I'd like to start pushing changes
to 8.5 whenever possible to avoid delaying the release too much.
On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <no...@gmail.com> wrote:
> I plan to commit the following as well.
> It's just a precautionery measure to avoid any future exploits
> https://github.com/apache/lucene-solr/pull/1085
>
> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
> <ic...@gmail.com> wrote:
> >
> > I've added a few critical fixes for SOLR-13662 to the branch. I tested
> > them thoroughly and got reviews for the fixes from Jan, Noble and
> > Eduardo.
> >
> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
> > >
> > > Hi Kevin,
> > >
> > > I'll defer to your judgement regarding whether this is safe to get in
> 8.4.
> > >
> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a
> écrit :
> > >>
> > >> Tim found SOLR-14086 which looks like a test only dependency leaking
> into compile caused by SOLR-14033. I put a patch up. I won't get to get it
> until later tonight or tomorrow ~24hrs from now.
> > >>
> > >> This causes any Solr Tika usage with 7z or a few other compressed
> file types (depends if they use commons-compress) to fail due to different
> classloaders being used.
> > >>
> > >> Kevin Risden
> > >>
> > >>
> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com>
> wrote:
> > >>>
> > >>> Deprecation of DIH is ready for review
> https://issues.apache.org/jira/browse/SOLR-14066
> > >>> One code change which is a WARN log at startup, other changes are
> documentation.
> > >>>
> > >>> Low risk and we’d like to deprecate sooner rather than later in 8.x.
> Your call Adrien.
> > >>>
> > >>> Jan
> > >>>
> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
> > >>>
> > >>> Let's get that one in as well, thanks Yonik.
> > >>>
> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com>
> wrote:
> > >>>>
> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not
> work.) . The fix is super simple and very low risk since it's encapsulated
> within the block only used when splitByPrefix=true.
> > >>>>
> > >>>> -Yonik
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Adrien
> > >>>
> > >>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> -----------------------------------------------------
> Noble Paul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Noble Paul <no...@gmail.com>.
I plan to commit the following as well.
It's just a precautionery measure to avoid any future exploits
https://github.com/apache/lucene-solr/pull/1085
On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya
<ic...@gmail.com> wrote:
>
> I've added a few critical fixes for SOLR-13662 to the branch. I tested
> them thoroughly and got reviews for the fixes from Jan, Noble and
> Eduardo.
>
> On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
> >
> > Hi Kevin,
> >
> > I'll defer to your judgement regarding whether this is safe to get in 8.4.
> >
> > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
> >>
> >> Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now.
> >>
> >> This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use commons-compress) to fail due to different classloaders being used.
> >>
> >> Kevin Risden
> >>
> >>
> >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
> >>>
> >>> Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066
> >>> One code change which is a WARN log at startup, other changes are documentation.
> >>>
> >>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
> >>>
> >>> Jan
> >>>
> >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
> >>>
> >>> Let's get that one in as well, thanks Yonik.
> >>>
> >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
> >>>>
> >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
> >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
> >>>>
> >>>> -Yonik
> >>>>
> >>>
> >>>
> >>> --
> >>> Adrien
> >>>
> >>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
-----------------------------------------------------
Noble Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
I've added a few critical fixes for SOLR-13662 to the branch. I tested
them thoroughly and got reviews for the fixes from Jan, Noble and
Eduardo.
On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <jp...@gmail.com> wrote:
>
> Hi Kevin,
>
> I'll defer to your judgement regarding whether this is safe to get in 8.4.
>
> Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
>>
>> Tim found SOLR-14086 which looks like a test only dependency leaking into compile caused by SOLR-14033. I put a patch up. I won't get to get it until later tonight or tomorrow ~24hrs from now.
>>
>> This causes any Solr Tika usage with 7z or a few other compressed file types (depends if they use commons-compress) to fail due to different classloaders being used.
>>
>> Kevin Risden
>>
>>
>> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
>>>
>>> Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066
>>> One code change which is a WARN log at startup, other changes are documentation.
>>>
>>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
>>>
>>> Jan
>>>
>>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>>>
>>> Let's get that one in as well, thanks Yonik.
>>>
>>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>>>>
>>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
>>>>
>>>> -Yonik
>>>>
>>>
>>>
>>> --
>>> Adrien
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Hi Kevin,
I'll defer to your judgement regarding whether this is safe to get in 8.4.
Le sam. 14 déc. 2019 à 21:00, Kevin Risden <kr...@apache.org> a écrit :
> Tim found SOLR-14086 which looks like a test only dependency leaking into
> compile caused by SOLR-14033. I put a patch up. I won't get to get it until
> later tonight or tomorrow ~24hrs from now.
>
> This causes any Solr Tika usage with 7z or a few other compressed file
> types (depends if they use commons-compress) to fail due to different
> classloaders being used.
>
> Kevin Risden
>
>
> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
>
>> Deprecation of DIH is ready for review
>> https://issues.apache.org/jira/browse/SOLR-14066
>> One code change which is a WARN log at startup, other changes are
>> documentation.
>>
>> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your
>> call Adrien.
>>
>> Jan
>>
>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>>
>> Let's get that one in as well, thanks Yonik.
>>
>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>>
>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.)
>>> . The fix is super simple and very low risk since it's encapsulated within
>>> the block only used when splitByPrefix=true.
>>>
>>> -Yonik
>>>
>>>
>>
>> --
>> Adrien
>>
>>
>>
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Kevin Risden <kr...@apache.org>.
Tim found SOLR-14086 which looks like a test only dependency leaking into
compile caused by SOLR-14033. I put a patch up. I won't get to get it until
later tonight or tomorrow ~24hrs from now.
This causes any Solr Tika usage with 7z or a few other compressed file
types (depends if they use commons-compress) to fail due to different
classloaders being used.
Kevin Risden
On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl <ja...@cominvent.com> wrote:
> Deprecation of DIH is ready for review
> https://issues.apache.org/jira/browse/SOLR-14066
> One code change which is a WARN log at startup, other changes are
> documentation.
>
> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your
> call Adrien.
>
> Jan
>
> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>
> Let's get that one in as well, thanks Yonik.
>
> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>
>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) .
>> The fix is super simple and very low risk since it's encapsulated within
>> the block only used when splitByPrefix=true.
>>
>> -Yonik
>>
>>
>
> --
> Adrien
>
>
>
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Go ahead Jan.
Le sam. 14 déc. 2019 à 20:09, Jan Høydahl <ja...@cominvent.com> a écrit :
> Deprecation of DIH is ready for review
> https://issues.apache.org/jira/browse/SOLR-14066
> One code change which is a WARN log at startup, other changes are
> documentation.
>
> Low risk and we’d like to deprecate sooner rather than later in 8.x. Your
> call Adrien.
>
> Jan
>
> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>
> Let's get that one in as well, thanks Yonik.
>
> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
>
>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
>> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) .
>> The fix is super simple and very low risk since it's encapsulated within
>> the block only used when splitByPrefix=true.
>>
>> -Yonik
>>
>>
>
> --
> Adrien
>
>
>
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Jan Høydahl <ja...@cominvent.com>.
Deprecation of DIH is ready for review https://issues.apache.org/jira/browse/SOLR-14066 <https://issues.apache.org/jira/browse/SOLR-14066>
One code change which is a WARN log at startup, other changes are documentation.
Low risk and we’d like to deprecate sooner rather than later in 8.x. Your call Adrien.
Jan
> 13. des. 2019 kl. 10:03 skrev Adrien Grand <jp...@gmail.com>:
>
> Let's get that one in as well, thanks Yonik.
>
> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <yseeley@gmail.com <ma...@gmail.com>> wrote:
> Heads up on https://issues.apache.org/jira/browse/SOLR-14079 <https://issues.apache.org/jira/browse/SOLR-14079>
> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) . The fix is super simple and very low risk since it's encapsulated within the block only used when splitByPrefix=true.
>
> -Yonik
>
>
>
> --
> Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Let's get that one in as well, thanks Yonik.
On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <ys...@gmail.com> wrote:
> Heads up on https://issues.apache.org/jira/browse/SOLR-14079
> Bad bug (autoscale triggers use async, so splitByPrefix does not work.) .
> The fix is super simple and very low risk since it's encapsulated within
> the block only used when splitByPrefix=true.
>
> -Yonik
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Yonik Seeley <ys...@gmail.com>.
Heads up on https://issues.apache.org/jira/browse/SOLR-14079
Bad bug (autoscale triggers use async, so splitByPrefix does not work.) .
The fix is super simple and very low risk since it's encapsulated within
the block only used when splitByPrefix=true.
-Yonik
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Done with these three:
SOLR-13978 Remove bloat from default configset
SOLR-14071 Untrusted configsets shouldn't be allowed to use <lib> directive
SOLR-14065 Deprecate Velocity
(First two were blockers)
On Fri, Dec 13, 2019 at 7:19 AM Ishan Chattopadhyaya
<ic...@gmail.com> wrote:
>
> Hi Adrien,
> I meant to include the following for the release branch, but it was
> already cut by the time I backported to branch_8x and I didn't realize
> it at the time. May I backport them now?
>
> SOLR-13978 Remove bloat from default configset
> SOLR-14071 Untrusted configsets shouldn't be allowed to use <lib> directive
> SOLR-14065 Deprecate Velocity
>
> I also wish to add the following deprecations into 8.4.
>
> SOLR-14067 Deprecate StatelessScriptUpdateProcessor
> SOLR-14066 Deprecate DIH
> SOLR-14070 Deprecate CloudSolrClient's ZKHost constructor
> SOLR-14072 Deprecate plugin loading using runtimelib
>
> Please let me know if that is fine by you, and I'll do this soon. I
> think it should not affect the stability of the release in any way.
> All of these deprecations are important for security purposes, besides
> making Solr more maintainable.
>
> Thanks and regards,
> Ishan
>
> On Fri, Dec 13, 2019 at 3:47 AM Andrzej Białecki <ab...@getopt.org> wrote:
> >
> > Done.
> >
> > On 12 Dec 2019, at 18:23, Adrien Grand <jp...@gmail.com> wrote:
> >
> > Thank you Andrzej. I noticed my initial suggestion for the RC date falls on Saturday, so I'll build on Monday instead. This will give some more CI cycles to the recent changes that have been merged.
> >
> > On Thu, Dec 12, 2019 at 6:14 PM Andrzej Białecki <ab...@getopt.org> wrote:
> >>
> >> Adrien,
> >> Jenkins discovered a bug in my recent fix for SOLR-13975 (see https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/), I’m testing a fix and should be able to commit it in an hour or so. I’d like to merge it to branch_8_4.
> >>
> >> On 12 Dec 2019, at 15:35, Adrien Grand <jp...@gmail.com> wrote:
> >>
> >> Thanks Uwe!
> >>
> >> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uw...@thetaphi.de> wrote:
> >>>
> >>> I enabled the Jenkins jobs on Policeman Jenkins.
> >>>
> >>>
> >>>
> >>> Uwe
> >>>
> >>>
> >>>
> >>> -----
> >>>
> >>> Uwe Schindler
> >>>
> >>> Achterdiek 19, D-28357 Bremen
> >>>
> >>> https://www.thetaphi.de
> >>>
> >>> eMail: uwe@thetaphi.de
> >>>
> >>>
> >>>
> >>> From: Adrien Grand <jp...@gmail.com>
> >>> Sent: Thursday, December 12, 2019 9:56 AM
> >>> To: Lucene Dev <de...@lucene.apache.org>
> >>> Subject: New branch and feature freeze for Lucene/Solr 8.4.0
> >>>
> >>>
> >>>
> >>> NOTICE:
> >>>
> >>> Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
> >>>
> >>> Please observe the normal rules:
> >>>
> >>> * No new features may be committed to the branch.
> >>> * Documentation patches, build patches and serious bug fixes may be
> >>> committed to the branch. However, you should submit all patches you
> >>> want to commit to Jira first to give others the chance to review
> >>> and possibly vote against the patch. Keep in mind that it is our
> >>> main intention to keep the branch as stable as possible.
> >>> * All patches that are intended for the branch should first be committed
> >>> to the unstable branch, merged into the stable branch, and then into
> >>> the current release branch.
> >>> * Normal unstable and stable branch development may continue as usual.
> >>> However, if you plan to commit a big change to the unstable branch
> >>> while the branch feature freeze is in effect, think twice: can't the
> >>> addition wait a couple more days? Merges of bug fixes into the branch
> >>> may become more difficult.
> >>> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
> >>> a release candidate build.
> >>>
> >>>
> >>>
> >>> --
> >>>
> >>> Adrien
> >>
> >>
> >>
> >> --
> >> Adrien
> >>
> >>
> >
> >
> > --
> > Adrien
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Ishan Chattopadhyaya <ic...@gmail.com>.
Hi Adrien,
I meant to include the following for the release branch, but it was
already cut by the time I backported to branch_8x and I didn't realize
it at the time. May I backport them now?
SOLR-13978 Remove bloat from default configset
SOLR-14071 Untrusted configsets shouldn't be allowed to use <lib> directive
SOLR-14065 Deprecate Velocity
I also wish to add the following deprecations into 8.4.
SOLR-14067 Deprecate StatelessScriptUpdateProcessor
SOLR-14066 Deprecate DIH
SOLR-14070 Deprecate CloudSolrClient's ZKHost constructor
SOLR-14072 Deprecate plugin loading using runtimelib
Please let me know if that is fine by you, and I'll do this soon. I
think it should not affect the stability of the release in any way.
All of these deprecations are important for security purposes, besides
making Solr more maintainable.
Thanks and regards,
Ishan
On Fri, Dec 13, 2019 at 3:47 AM Andrzej Białecki <ab...@getopt.org> wrote:
>
> Done.
>
> On 12 Dec 2019, at 18:23, Adrien Grand <jp...@gmail.com> wrote:
>
> Thank you Andrzej. I noticed my initial suggestion for the RC date falls on Saturday, so I'll build on Monday instead. This will give some more CI cycles to the recent changes that have been merged.
>
> On Thu, Dec 12, 2019 at 6:14 PM Andrzej Białecki <ab...@getopt.org> wrote:
>>
>> Adrien,
>> Jenkins discovered a bug in my recent fix for SOLR-13975 (see https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/), I’m testing a fix and should be able to commit it in an hour or so. I’d like to merge it to branch_8_4.
>>
>> On 12 Dec 2019, at 15:35, Adrien Grand <jp...@gmail.com> wrote:
>>
>> Thanks Uwe!
>>
>> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uw...@thetaphi.de> wrote:
>>>
>>> I enabled the Jenkins jobs on Policeman Jenkins.
>>>
>>>
>>>
>>> Uwe
>>>
>>>
>>>
>>> -----
>>>
>>> Uwe Schindler
>>>
>>> Achterdiek 19, D-28357 Bremen
>>>
>>> https://www.thetaphi.de
>>>
>>> eMail: uwe@thetaphi.de
>>>
>>>
>>>
>>> From: Adrien Grand <jp...@gmail.com>
>>> Sent: Thursday, December 12, 2019 9:56 AM
>>> To: Lucene Dev <de...@lucene.apache.org>
>>> Subject: New branch and feature freeze for Lucene/Solr 8.4.0
>>>
>>>
>>>
>>> NOTICE:
>>>
>>> Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
>>>
>>> Please observe the normal rules:
>>>
>>> * No new features may be committed to the branch.
>>> * Documentation patches, build patches and serious bug fixes may be
>>> committed to the branch. However, you should submit all patches you
>>> want to commit to Jira first to give others the chance to review
>>> and possibly vote against the patch. Keep in mind that it is our
>>> main intention to keep the branch as stable as possible.
>>> * All patches that are intended for the branch should first be committed
>>> to the unstable branch, merged into the stable branch, and then into
>>> the current release branch.
>>> * Normal unstable and stable branch development may continue as usual.
>>> However, if you plan to commit a big change to the unstable branch
>>> while the branch feature freeze is in effect, think twice: can't the
>>> addition wait a couple more days? Merges of bug fixes into the branch
>>> may become more difficult.
>>> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
>>> a release candidate build.
>>>
>>>
>>>
>>> --
>>>
>>> Adrien
>>
>>
>>
>> --
>> Adrien
>>
>>
>
>
> --
> Adrien
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Andrzej Białecki <ab...@getopt.org>.
Done.
> On 12 Dec 2019, at 18:23, Adrien Grand <jp...@gmail.com> wrote:
>
> Thank you Andrzej. I noticed my initial suggestion for the RC date falls on Saturday, so I'll build on Monday instead. This will give some more CI cycles to the recent changes that have been merged.
>
> On Thu, Dec 12, 2019 at 6:14 PM Andrzej Białecki <ab@getopt.org <ma...@getopt.org>> wrote:
> Adrien,
> Jenkins discovered a bug in my recent fix for SOLR-13975 (see https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/ <https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/>), I’m testing a fix and should be able to commit it in an hour or so. I’d like to merge it to branch_8_4.
>
>> On 12 Dec 2019, at 15:35, Adrien Grand <jpountz@gmail.com <ma...@gmail.com>> wrote:
>>
>> Thanks Uwe!
>>
>> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uwe@thetaphi.de <ma...@thetaphi.de>> wrote:
>> I enabled the Jenkins jobs on Policeman Jenkins.
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de <https://www.thetaphi.de/>
>> eMail: uwe@thetaphi.de <ma...@thetaphi.de>
>>
>>
>> From: Adrien Grand <jpountz@gmail.com <ma...@gmail.com>>
>> Sent: Thursday, December 12, 2019 9:56 AM
>> To: Lucene Dev <dev@lucene.apache.org <ma...@lucene.apache.org>>
>> Subject: New branch and feature freeze for Lucene/Solr 8.4.0
>>
>>
>>
>> NOTICE:
>>
>> Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
>>
>> Please observe the normal rules:
>>
>> * No new features may be committed to the branch.
>> * Documentation patches, build patches and serious bug fixes may be
>> committed to the branch. However, you should submit all patches you
>> want to commit to Jira first to give others the chance to review
>> and possibly vote against the patch. Keep in mind that it is our
>> main intention to keep the branch as stable as possible.
>> * All patches that are intended for the branch should first be committed
>> to the unstable branch, merged into the stable branch, and then into
>> the current release branch.
>> * Normal unstable and stable branch development may continue as usual.
>> However, if you plan to commit a big change to the unstable branch
>> while the branch feature freeze is in effect, think twice: can't the
>> addition wait a couple more days? Merges of bug fixes into the branch
>> may become more difficult.
>> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
>> a release candidate build.
>>
>>
>>
>> --
>>
>> Adrien
>>
>>
>>
>> --
>> Adrien
>
>
>
> --
> Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Thank you Andrzej. I noticed my initial suggestion for the RC date falls on
Saturday, so I'll build on Monday instead. This will give some more CI
cycles to the recent changes that have been merged.
On Thu, Dec 12, 2019 at 6:14 PM Andrzej Białecki <ab...@getopt.org> wrote:
> Adrien,
> Jenkins discovered a bug in my recent fix for SOLR-13975 (see
> https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/), I’m
> testing a fix and should be able to commit it in an hour or so. I’d like to
> merge it to branch_8_4.
>
> On 12 Dec 2019, at 15:35, Adrien Grand <jp...@gmail.com> wrote:
>
> Thanks Uwe!
>
> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uw...@thetaphi.de> wrote:
>
>> I enabled the Jenkins jobs on Policeman Jenkins.
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de
>>
>> eMail: uwe@thetaphi.de
>>
>>
>>
>> *From:* Adrien Grand <jp...@gmail.com>
>> *Sent:* Thursday, December 12, 2019 9:56 AM
>> *To:* Lucene Dev <de...@lucene.apache.org>
>> *Subject:* New branch and feature freeze for Lucene/Solr 8.4.0
>>
>>
>>
>> NOTICE:
>>
>> Branch branch_8_4 has been cut and versions updated to 8.5 on stable
>> branch.
>>
>> Please observe the normal rules:
>>
>> * No new features may be committed to the branch.
>> * Documentation patches, build patches and serious bug fixes may be
>> committed to the branch. However, you should submit all patches you
>> want to commit to Jira first to give others the chance to review
>> and possibly vote against the patch. Keep in mind that it is our
>> main intention to keep the branch as stable as possible.
>> * All patches that are intended for the branch should first be committed
>> to the unstable branch, merged into the stable branch, and then into
>> the current release branch.
>> * Normal unstable and stable branch development may continue as usual.
>> However, if you plan to commit a big change to the unstable branch
>> while the branch feature freeze is in effect, think twice: can't the
>> addition wait a couple more days? Merges of bug fixes into the branch
>> may become more difficult.
>> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
>> a release candidate build.
>>
>>
>>
>> --
>>
>> Adrien
>>
>
>
> --
> Adrien
>
>
>
--
Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Andrzej Białecki <ab...@getopt.org>.
Adrien,
Jenkins discovered a bug in my recent fix for SOLR-13975 (see https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/ <https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Windows/591/>), I’m testing a fix and should be able to commit it in an hour or so. I’d like to merge it to branch_8_4.
> On 12 Dec 2019, at 15:35, Adrien Grand <jp...@gmail.com> wrote:
>
> Thanks Uwe!
>
> On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uwe@thetaphi.de <ma...@thetaphi.de>> wrote:
> I enabled the Jenkins jobs on Policeman Jenkins.
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de <https://www.thetaphi.de/>
> eMail: uwe@thetaphi.de <ma...@thetaphi.de>
>
>
> From: Adrien Grand <jpountz@gmail.com <ma...@gmail.com>>
> Sent: Thursday, December 12, 2019 9:56 AM
> To: Lucene Dev <dev@lucene.apache.org <ma...@lucene.apache.org>>
> Subject: New branch and feature freeze for Lucene/Solr 8.4.0
>
>
>
> NOTICE:
>
> Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
>
> Please observe the normal rules:
>
> * No new features may be committed to the branch.
> * Documentation patches, build patches and serious bug fixes may be
> committed to the branch. However, you should submit all patches you
> want to commit to Jira first to give others the chance to review
> and possibly vote against the patch. Keep in mind that it is our
> main intention to keep the branch as stable as possible.
> * All patches that are intended for the branch should first be committed
> to the unstable branch, merged into the stable branch, and then into
> the current release branch.
> * Normal unstable and stable branch development may continue as usual.
> However, if you plan to commit a big change to the unstable branch
> while the branch feature freeze is in effect, think twice: can't the
> addition wait a couple more days? Merges of bug fixes into the branch
> may become more difficult.
> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
> a release candidate build.
>
>
>
> --
>
> Adrien
>
>
>
> --
> Adrien
Re: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Adrien Grand <jp...@gmail.com>.
Thanks Uwe!
On Thu, Dec 12, 2019 at 3:33 PM Uwe Schindler <uw...@thetaphi.de> wrote:
> I enabled the Jenkins jobs on Policeman Jenkins.
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de
>
> eMail: uwe@thetaphi.de
>
>
>
> *From:* Adrien Grand <jp...@gmail.com>
> *Sent:* Thursday, December 12, 2019 9:56 AM
> *To:* Lucene Dev <de...@lucene.apache.org>
> *Subject:* New branch and feature freeze for Lucene/Solr 8.4.0
>
>
>
> NOTICE:
>
> Branch branch_8_4 has been cut and versions updated to 8.5 on stable
> branch.
>
> Please observe the normal rules:
>
> * No new features may be committed to the branch.
> * Documentation patches, build patches and serious bug fixes may be
> committed to the branch. However, you should submit all patches you
> want to commit to Jira first to give others the chance to review
> and possibly vote against the patch. Keep in mind that it is our
> main intention to keep the branch as stable as possible.
> * All patches that are intended for the branch should first be committed
> to the unstable branch, merged into the stable branch, and then into
> the current release branch.
> * Normal unstable and stable branch development may continue as usual.
> However, if you plan to commit a big change to the unstable branch
> while the branch feature freeze is in effect, think twice: can't the
> addition wait a couple more days? Merges of bug fixes into the branch
> may become more difficult.
> * Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
> a release candidate build.
>
>
>
> --
>
> Adrien
>
--
Adrien
RE: New branch and feature freeze for Lucene/Solr 8.4.0
Posted by Uwe Schindler <uw...@thetaphi.de>.
I enabled the Jenkins jobs on Policeman Jenkins.
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
<https://www.thetaphi.de> https://www.thetaphi.de
eMail: uwe@thetaphi.de
From: Adrien Grand <jp...@gmail.com>
Sent: Thursday, December 12, 2019 9:56 AM
To: Lucene Dev <de...@lucene.apache.org>
Subject: New branch and feature freeze for Lucene/Solr 8.4.0
NOTICE:
Branch branch_8_4 has been cut and versions updated to 8.5 on stable branch.
Please observe the normal rules:
* No new features may be committed to the branch.
* Documentation patches, build patches and serious bug fixes may be
committed to the branch. However, you should submit all patches you
want to commit to Jira first to give others the chance to review
and possibly vote against the patch. Keep in mind that it is our
main intention to keep the branch as stable as possible.
* All patches that are intended for the branch should first be committed
to the unstable branch, merged into the stable branch, and then into
the current release branch.
* Normal unstable and stable branch development may continue as usual.
However, if you plan to commit a big change to the unstable branch
while the branch feature freeze is in effect, think twice: can't the
addition wait a couple more days? Merges of bug fixes into the branch
may become more difficult.
* Only Jira issues with Fix version 8.4 and priority "Blocker" will delay
a release candidate build.
--
Adrien