You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/04 01:33:28 UTC
[GitHub] [druid] FrankChen021 commented on a change in pull request #12302: perf: core TextReader use a smaller default buffer
FrankChen021 commented on a change in pull request #12302:
URL: https://github.com/apache/druid/pull/12302#discussion_r819198659
##########
File path: core/src/main/java/org/apache/druid/data/input/TextReader.java
##########
@@ -55,7 +56,8 @@ public InputRowSchema getInputRowSchema()
throws IOException
{
final LineIterator delegate = new LineIterator(
- new InputStreamReader(source.open(), StringUtils.UTF8_STRING)
+ // create a small buffer, otherwise LineIterator creates a default 8KB buffer
+ new BufferedReader(new InputStreamReader(source.open(), StringUtils.UTF8_STRING), 256)
Review comment:
What is the rational that 256 is used for the buffer size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org