[GitHub] surekhasaharan commented on a change in pull request #7043: 2528 Replace Incremental Index Global Flags with Getters

[GitBox <gi...@apache.org>]

surekhasaharan commented on a change in pull request #7043: 2528 Replace Incremental Index Global Flags with Getters
URL: https://github.com/apache/incubator-druid/pull/7043#discussion_r256669455
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
 ##########
 @@ -785,9 +780,29 @@ public int size()
     return numEntries.get();
   }
 
-  public long getBytesInMemory()
+  public boolean getDeserializeComplexMetrics()
   {
-    return bytesInMemory.get();
+    return deserializeComplexMetrics;
+  }
+
+  public boolean getReportParseExceptions()
+  {
+    return reportParseExceptions;
+  }
+
+  public AtomicInteger getNumEntries()
+  {
+    return numEntries;
+  }
+
+  public AggregatorFactory[] getMetrics()
 
 Review comment:
   Do all of these getters need to be public ? I think except `getBytesInMemory()`, others can be default package access.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org