You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by caneGuy <gi...@git.apache.org> on 2018/04/23 10:24:48 UTC
[GitHub] spark pull request #21127: [SPARK-24052][CORE][UI] Add spark version informa...
GitHub user caneGuy opened a pull request:
https://github.com/apache/spark/pull/21127
[SPARK-24052][CORE][UI] Add spark version information on environment page
## What changes were proposed in this pull request?
Since we may have multiple version in production cluster,we can showing some information on environment page like below:
## How was this patch tested?
Exist UT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caneGuy/spark zhoukang/add-sparkversion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21127
----
commit a9c6563693e598f9f8babf899790751a6b73fd4c
Author: zhoukang <zh...@...>
Date: 2018-04-23T10:17:50Z
[SPARK][CORE][UI] Add spark version information on environment page
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21127
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89714/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21127
Version info is already available, in the code and in the UI. "Compiled by" info has never struck me as useful. The rest is from the env. I don't think this adds anything.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21127: [SPARK-24052][CORE][UI] Add spark version informa...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy closed the pull request at:
https://github.com/apache/spark/pull/21127
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21127
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/21127
Ok i will close this pr.
Thanks for your time @srowen @vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21127
**[Test build #89714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89714/testReport)** for PR 21127 at commit [`a9c6563`](https://github.com/apache/spark/commit/a9c6563693e598f9f8babf899790751a6b73fd4c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21127
**[Test build #89714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89714/testReport)** for PR 21127 at commit [`a9c6563`](https://github.com/apache/spark/commit/a9c6563693e598f9f8babf899790751a6b73fd4c).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public final class Version `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/21127
How about the other information?
As mentioned,the build info @vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21127
The Spark version already shows next to the Spark logo on every page in the UI?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21127
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21127
The SHS shows the application's Spark version in the title (or the SHS version in the listing page).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21127
We already have SparkBuildInfo for this purpose.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21127: [SPARK-24052][CORE][UI] Add spark version information on...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/21127
It is version for the historyserver @vanzin
May be i can reuse SparkBuildInfo? @srowen @vanzin
Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org