[GitHub] [superset] dpgaspar commented on a change in pull request #13353: feat: add Firebird DB engine spec

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #13353:
URL: https://github.com/apache/superset/pull/13353#discussion_r583787590



##########
File path: superset/db_engine_specs/firebird.py
##########
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from datetime import datetime
+from typing import Optional
+
+from superset.db_engine_specs.base import BaseEngineSpec, LimitMethod
+from superset.utils import core as utils
+
+
+class FirebirdEngineSpec(BaseEngineSpec):
+    """Engine for Google spreadsheets"""

Review comment:
       nit: Engine for Firebird

##########
File path: superset/sql_lab.py
##########
@@ -205,7 +206,8 @@ def execute_sql_statement(
     ):
         if SQL_MAX_ROW and (not query.limit or query.limit > SQL_MAX_ROW):
             query.limit = SQL_MAX_ROW
-        if query.limit:
+        # do not apply limit for databases that don't support LIMIT in the query
+        if query.limit and db_engine_spec.limit_method != LimitMethod.FETCH_MANY:

Review comment:
       Should we change this to base db_engine_spec instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org