You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/27 11:53:01 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

TeslaCN commented on a change in pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665#discussion_r512630131



##########
File path: elasticjob-infra/elasticjob-registry-center/src/test/java/org/apache/shardingsphere/elasticjob/reg/zookeeper/ZookeeperElectionServiceTest.java
##########
@@ -29,9 +29,12 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
+import org.mockito.internal.verification.VerificationModeFactory;

Review comment:
       Should we use the Class define under package `internal`?
   Maybe using `org.mockito.Mockito#atLeastOnce` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org