[jira] [Updated] (LUCENE-5889) AnalyzingInfixSuggester should expose commit()

["Varun Thacker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Varun Thacker updated LUCENE-5889:
----------------------------------

    Attachment: LUCENE-5889.patch

Patch which exposes commit.

I also added param to the constructor 'commitOnBuild' . I felt it was a good option to have and especially useful in Solr where we just expose the build() method for all suggesters. 

[~mikemccand] - Also regarding your comments on the user list regarding the NPE's in add(), update()  I think it would be more convenient for a user to keep calling add() in a loop and then call commit() to build his suggester. It saves the user the hassle of creating a Iterator. If you think otherwise I could change it to IllegalStateException.


> AnalyzingInfixSuggester should expose commit()
> ----------------------------------------------
>
>                 Key: LUCENE-5889
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5889
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spellchecker
>            Reporter: Mike Sokolov
>         Attachments: LUCENE-5889.patch
>
>
> There is no way short of close() for a user of AnalyzingInfixSuggester to cause it to commit() its underlying index: only refresh() is provided.  But callers might want to ensure the index is flushed to disk without closing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org