You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/05/24 07:41:04 UTC
[kudu-CR](branch-1.17.x) [client] fix API non-compliance in KuduUpsertIgnore
Hello Alexey Serbin, Abhishek Chennaka,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19922
to review the following change.
Change subject: [client] fix API non-compliance in KuduUpsertIgnore
......................................................................
[client] fix API non-compliance in KuduUpsertIgnore
Kudu C++ client API is still assumed to be C++98 compatible. That's
an invariant that has been in place in the very beginning of 1.x version
history, so it should be kept as-is unless changing the major version.
Prior to this patch, client_examples-test.sh would fail while checking
a standalone compilation of kudu/client/write_op.h
This is a follow-up to ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0.
Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Reviewed-on: http://gerrit.cloudera.org:8080/19765
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/write_op.h
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/19922/1
--
To view, visit http://gerrit.cloudera.org:8080/19922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Gerrit-Change-Number: 19922
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.17.x) [client] fix API non-compliance in KuduUpsertIgnore
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19922 )
Change subject: [client] fix API non-compliance in KuduUpsertIgnore
......................................................................
[client] fix API non-compliance in KuduUpsertIgnore
Kudu C++ client API is still assumed to be C++98 compatible. That's
an invariant that has been in place in the very beginning of 1.x version
history, so it should be kept as-is unless changing the major version.
Prior to this patch, client_examples-test.sh would fail while checking
a standalone compilation of kudu/client/write_op.h
This is a follow-up to ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0.
Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Reviewed-on: http://gerrit.cloudera.org:8080/19765
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/19922
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/write_op.h
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Gerrit-Change-Number: 19922
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [client] fix API non-compliance in KuduUpsertIgnore
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19922 )
Change subject: [client] fix API non-compliance in KuduUpsertIgnore
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Gerrit-Change-Number: 19922
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 May 2023 11:34:18 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [client] fix API non-compliance in KuduUpsertIgnore
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19922 )
Change subject: [client] fix API non-compliance in KuduUpsertIgnore
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I83f4e65bc3811ac701f5908beb480b39ad413641
Gerrit-Change-Number: 19922
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 May 2023 02:25:29 +0000
Gerrit-HasComments: No