[GitHub] [helix] jiajunwang commented on issue #859: Add 'synchronized' key word to delete method in CustomizedStateProvider

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #859: Add 'synchronized' key word to delete method in CustomizedStateProvider
URL: https://github.com/apache/helix/pull/859#issuecomment-595375938
 
 
   > @jiajunwang Please see line 76, we rely on the record we get from zk for the update, and set the record to the local map to update the znode. So I think if there is any change during get and update, the data would be messed up.
   
   I see your point. But if we are using the "updater", and use it in the correct way, I believe we don't need this additional sync. Actually, let's address this problem in this PR. Make the logic around 76 use updater.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org