You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "arshadmohammad (via GitHub)" <gi...@apache.org> on 2023/11/07 18:47:28 UTC
Re: [PR] AMBARI-26000: Make Ambari supports Python3 environment [ambari]
arshadmohammad commented on code in PR #3751:
URL: https://github.com/apache/ambari/pull/3751#discussion_r1385401084
##########
ambari-common/src/main/python/ambari_commons/repo_manager/yum_manager.py:
##########
@@ -352,7 +330,7 @@ def rpm_check_package_available(self, name):
regex = re.compile(name_regex)
for package in packages:
- if regex.match(package['name']):
+ if regex.match(package['name'].decode()):
Review Comment:
> Sometimes the return of `package['name']` is not `str`, so I think we need to add a judgement this place.
yes, please add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org