You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "Arthur Ryman (JIRA)" <ji...@apache.org> on 2006/09/26 16:07:51 UTC

[jira] Created: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

NPE on W3C Test Case Storage-4G/storage.wsdl
--------------------------------------------

                 Key: WODEN-59
                 URL: http://issues.apache.org/jira/browse/WODEN-59
             Project: Woden
          Issue Type: Bug
            Reporter: Arthur Ryman


I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Updated: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WODEN-59?page=all ]

John Kaputin updated WODEN-59:
------------------------------

    Component/s: Parser

I have started to define a Woden representation for MEPs to use for identifying the default value for {message label} .

I think the logic for determining a default value for {message label} is this:

If the messageLabel attribute of <input> <output> <infault> or <outfault> is absent, match the {direction} of the corresponding InterfaceMessageReference or InteraceFaultReference to the Direction of a message in the MEP specified by the parent InterfaceOperation and use the Label of that matching MEP message as the default value for the {message label} property of the InterfaceMessageReference or InterfaceFaultReference.

Other possible requirements are:
1. for this representation to be extendable for user-defined MEPs
2. to cater for ambiguity, e.g. if {direction} matches with more than one MEP message

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Closed: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "Arthur Ryman (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WODEN-59?page=all ]

Arthur Ryman closed WODEN-59.
-----------------------------


No more NPE. Thx.

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>         Attachments: WODEN-59patch.txt
>
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "Arthur Ryman (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/WODEN-59?page=comments#action_12438723 ] 
            
Arthur Ryman commented on WODEN-59:
-----------------------------------

Jeremy, sounds right. The message labels are optional from the XML point of view but not from the Component Model point of view. Woden must apply the defaullting rules as you described.

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>            Reporter: Arthur Ryman
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/WODEN-59?page=comments#action_12438137 ] 
            
Jeremy Hughes commented on WODEN-59:
------------------------------------

CmWriter line 375 does:

        out.write("messageLabel", component.getMessageLabel().toString());

The MessageLabel object returned is null. It is null because there isn't one specified in the <outfault> in the WSDL - which is allowed as the attribute is optional. However, the {message label} property is a required one on the InterfaceFaultReference component so we need to derive one. I believe in this case the {message label} should be 'Out'. Why? Because the {message exchange pattern} is http://www.w3.org/2006/01/wsdl/in-out which is defined in §2.3.3 of part 2 of the spec as:

-----
2.3.3 In-Out

This pattern consists of exactly two messages, in order, as follows:†

   1. A message:
          * indicated by a Interface Message Reference component whose {message label} is "In" and {direction} is "in"
          * received from some node N
   2. A message:
          * indicated by a Interface Message Reference component whose {message label} is "Out" and {direction} is "out"
          * sent to node N

This pattern uses the rule 2.2.1 Fault Replaces Message.†

An operation using this message exchange pattern has a {message exchange pattern} property with the value "http://www.w3.org/@@@@/@@/wsdl/in-out". 
-----

Under these rules, the only possible value for {message label} is 'Out' because the only way a fault message can occur is by using the 'fault replaces message' rule on the 2nd (Out) message. For this MEP there is only one possibility however for other MEPs the answer may be ambiguous. What should we do in these circumstances? Assuming we can figure that out we should have an object representation of each MEP so we can figure out the 'default' message label on a per message level. 

Alternatively we could ask the working group to make messageLabel a required attribute, thereby making it trivial to populate the {message level} property.

Any comments?

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>            Reporter: Arthur Ryman
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Resolved: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WODEN-59?page=all ]

John Kaputin resolved WODEN-59.
-------------------------------

    Resolution: Fixed

Fixed. rev 473144.

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>         Attachments: WODEN-59patch.txt
>
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Updated: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "Anonymous (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WODEN-59?page=all ]


    Attachment: WODEN-59patch.txt

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>         Attachments: WODEN-59patch.txt
>
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Assigned: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/WODEN-59?page=all ]

John Kaputin reassigned WODEN-59:
---------------------------------

    Assignee: John Kaputin

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org


[jira] Commented: (WODEN-59) NPE on W3C Test Case Storage-4G/storage.wsdl

Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/WODEN-59?page=comments#action_12448630 ] 
            
John Kaputin commented on WODEN-59:
-----------------------------------

I have implemented a temporary solution for the time being that reuses the message label defaulting behaviour  in the BaseWSDLReader  methods parseInterfaceMessageReference and parseBindingMessageReference.  This behaviour has been copied to the parseInterfaceFaultReference method. That method now derives a default value if the msgLabel attribute is absent in the WSDL and this fixes the NPE that was occurring with test case Storage-4G. The attached patch has been committed to SVN.

This solution will handle the 3 remaining MEPs defined in the Part 2 Adjuncts spec; in-only, robust in-only and in-out. However, a more extensible solution is still needed to cater for possible user-defined MEPs.  I will raise a new JIRA to capture this requirement.

> NPE on W3C Test Case Storage-4G/storage.wsdl
> --------------------------------------------
>
>                 Key: WODEN-59
>                 URL: http://issues.apache.org/jira/browse/WODEN-59
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Arthur Ryman
>         Assigned To: John Kaputin
>         Attachments: WODEN-59patch.txt
>
>
> I ran ant-test/build.xml and hit a NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org