You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/12 10:19:10 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #16784: [FLINK-23430][runtime][checkpoint] Allows taking snapshots for operator coordinators which all corresponding tasks finished

rkhachatryan commented on a change in pull request #16784:
URL: https://github.com/apache/flink/pull/16784#discussion_r687578029



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -487,8 +487,8 @@ private void fulfillFullyFinishedOperatorStates() {
                 OperatorState operatorState =
                         operatorStates.get(operatorID.getGeneratedOperatorID());
                 checkState(
-                        operatorState == null,
-                        "There should be no states reported for fully finished operators");
+                        operatorState == null || operatorState.getSubtaskStates().size() == 0,

Review comment:
       nit: use `isEmpty`? move the check into the `operatorState` (as e.g. `hasSubtaskState` method)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org