You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/06/10 00:48:07 UTC
[jira] Created: (HBASE-1507) CMS as default JVM
CMS as default JVM
------------------
Key: HBASE-1507
URL: https://issues.apache.org/jira/browse/HBASE-1507
Project: Hadoop HBase
Issue Type: Improvement
Reporter: stack
Fix For: 0.20.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1507) CMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reassigned HBASE-1507:
----------------------------------
Assignee: ryan rawson
> CMS as default JVM
> ------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: ryan rawson
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1507) iCMS as default JVM
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719329#action_12719329 ]
stack commented on HBASE-1507:
------------------------------
First, yes, my original commit was bad. Sorry about that.
Rather than Ryan's patch where the default is set in hbase-conf.env, rather why not follow convention where we set a default if environment variable is empty:
{code}
Index: bin/hbase
===================================================================
--- bin/hbase (revision 784502)
+++ bin/hbase (working copy)
@@ -206,7 +206,9 @@
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+if [ "$HBASE_OPTS" = "" ]; then
+ HBASE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+fi
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
{code}
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1507) iCMS as default JVM
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719219#action_12719219 ]
Dave Latham commented on HBASE-1507:
------------------------------------
With 8 cores, I've been running without -XX:+CMSIncrementalMode. It looks like to disable it, I'll now have to edit bin/hbase, which is a bit counterintuitive to me, as I would have expected to just edit conf/hbase-env.sh.
Can we have this only in conf/hbase-env.sh, but uncommented by default?
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1507) iCMS as default JVM
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1507.
--------------------------
Resolution: Fixed
Committed Ryan's suggested patch (with the ddlatham +1).
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-1507) iCMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719225#action_12719225 ]
ryan rawson edited comment on HBASE-1507 at 6/13/09 9:44 PM:
-------------------------------------------------------------
I agree, the config should be in hbase-env.sh since tuning the GC is a fairly frequent activity.
Here is my proposed patch different:
{{index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
# Extra Java runtime options.
# Below are what we set by default. For more on why as well as other possible
# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers}}
was (Author: ryanobjc):
I agree, the config should be in hbase-env.sh since tuning the GC is a fairly frequent activity.
Here is my proposed patch different:
index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
# Extra Java runtime options.
# Below are what we set by default. For more on why as well as other possible
# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1507) iCMS as default JVM
Posted by "Dave Latham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719261#action_12719261 ]
Dave Latham commented on HBASE-1507:
------------------------------------
+1 to Ryan's proposed patch.
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1507) CMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718712#action_12718712 ]
ryan rawson commented on HBASE-1507:
------------------------------------
the arguments are:
-XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode
> CMS as default JVM
> ------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: ryan rawson
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1507) iCMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719225#action_12719225 ]
ryan rawson commented on HBASE-1507:
------------------------------------
I agree, the config should be in hbase-env.sh since tuning the GC is a fairly frequent activity.
Here is my proposed patch different:
index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
# Extra Java runtime options.
# Below are what we set by default. For more on why as well as other possible
# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1507) CMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson reassigned HBASE-1507:
----------------------------------
Assignee: stack (was: ryan rawson)
> CMS as default JVM
> ------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1507) iCMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson updated HBASE-1507:
-------------------------------
Summary: iCMS as default JVM (was: CMS as default JVM)
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1507) iCMS as default JVM
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1507.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I tested and committed this:
{code}
Index: conf/hbase-env.sh
===================================================================
--- conf/hbase-env.sh (revision 783986)
+++ conf/hbase-env.sh (working copy)
@@ -30,8 +30,10 @@
# The maximum amount of heap to use, in MB. Default is 1000.
# export HBASE_HEAPSIZE=1000
-# Extra Java runtime options. Empty by default.
-# export HBASE_OPTS=-server
+# Extra Java runtime options.
+# Below are what we set by default. For more on why as well as other possible
+# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
+# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
Index: bin/hbase
===================================================================
--- bin/hbase (revision 783986)
+++ bin/hbase (working copy)
@@ -206,7 +206,7 @@
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
{code}
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1507) iCMS as default JVM
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-1507:
--------------------------
Reopening to address Dave's criticism.
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-1507) iCMS as default JVM
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719225#action_12719225 ]
ryan rawson edited comment on HBASE-1507 at 6/13/09 9:45 PM:
-------------------------------------------------------------
I agree, the config should be in hbase-env.sh since tuning the GC is a fairly frequent activity.
Here is my proposed patch different:
{noformat}
index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
# Extra Java runtime options.
# Below are what we set by default. For more on why as well as other possible
# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
{noformat}
was (Author: ryanobjc):
I agree, the config should be in hbase-env.sh since tuning the GC is a fairly frequent activity.
Here is my proposed patch different:
{{index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
# and are named like the following: java_pid21612.hprof. Apparently it doesn't
# 'cost' to have this flag enabled. Its a 1.6 flag only. See:
# http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
# Extra Java runtime options.
# Below are what we set by default. For more on why as well as other possible
# settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run. $HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers}}
> iCMS as default JVM
> -------------------
>
> Key: HBASE-1507
> URL: https://issues.apache.org/jira/browse/HBASE-1507
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.