You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/06/24 12:22:32 UTC

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-mobile-spec/pull/77

    CB-7011 (WP8) proper file name if windowsphone

    in case of platformId === 'windowsphone' it will use a proper path to determine if the file exists or not, instead of just thow a ENCODING_ERR error code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-mobile-spec CB-7011

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-mobile-spec/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 0364c92f193268823dec293e36dae6ad4b20cc57
Author: Martin Gonzalez <ma...@gmail.com>
Date:   2014-06-24T10:07:33Z

    CB-7011 (WP8) proper file name if windowsphone
    
    in case of platformId === 'windowsphone' it will use a proper path to
    determine if exists or not, instead of just thow a ENCODING_ERR error
    code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

Posted by martincgg <gi...@git.apache.org>.
Github user martincgg closed the pull request at:

    https://github.com/apache/cordova-mobile-spec/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/77#issuecomment-51417963
  
    merge conflicts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7011 (WP8) proper file name i...

Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/77#issuecomment-51419444
  
    no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---