You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "cyb1103 (via GitHub)" <gi...@apache.org> on 2024/08/24 17:01:08 UTC
[PR] [#8579]Update the startup script of RocketMQ on Windows [rocketmq]
cyb1103 opened a new pull request, #8580:
URL: https://github.com/apache/rocketmq/pull/8580
### Which Issue(s) This PR Fixes
[8579](https://github.com/apache/rocketmq/issues/8579)
Fixes #issue_id
### Brief Description
There is a problem with obtaining the JDK version script in Windows, so I modified it;
I don't know much about different JDK versions (mainly divided by 17), and only made modifications to the issues I found
### How Did You Test This Change?
I can run it normally on my computer
"JAVA_MAJOR_VERSION=**" is the log I added during debugging
run with java 17

run with java 8

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#8579]Update the startup script of RocketMQ on Windows [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8580:
URL: https://github.com/apache/rocketmq/pull/8580#issuecomment-2311409686
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.23%. Comparing base [(`e8d87b1`)](https://app.codecov.io/gh/apache/rocketmq/commit/e8d87b195d6c639ed376feaa585e623c4a4e4f97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f02d132`)](https://app.codecov.io/gh/apache/rocketmq/commit/f02d1322a56f9a9b79f4c2732e6dac0f9b8ab202?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8580 +/- ##
=============================================
- Coverage 47.27% 47.23% -0.05%
+ Complexity 11453 11443 -10
=============================================
Files 1275 1275
Lines 89242 89242
Branches 11470 11470
=============================================
- Hits 42185 42149 -36
- Misses 41861 41888 +27
- Partials 5196 5205 +9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8580?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8579] Update the startup script of RocketMQ on Windows [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8580:
URL: https://github.com/apache/rocketmq/pull/8580#issuecomment-3240527462
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8579] Update the startup script of RocketMQ on Windows [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8580:
URL: https://github.com/apache/rocketmq/pull/8580#issuecomment-3235313102
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8579] Update the startup script of RocketMQ on Windows [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8580: [ISSUE #8579] Update the startup script of RocketMQ on Windows
URL: https://github.com/apache/rocketmq/pull/8580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org