You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2023/06/01 15:06:20 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #20349: [fix](olap) deletion statement with space conditions did not take effect
mrhhsg opened a new pull request, #20349:
URL: https://github.com/apache/doris/pull/20349
## Proposed changes
Deletion statement like this:
```sql
delete from tb where k1 = ' ';
```
The rows whose `k1`'s value is ' ' will not be deleted.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #20349:
URL: https://github.com/apache/doris/pull/20349#issuecomment-1572242342
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #20349:
URL: https://github.com/apache/doris/pull/20349#discussion_r1213813762
##########
be/src/olap/delete_handler.cpp:
##########
@@ -110,7 +110,7 @@ std::string DeleteHandler::construct_sub_predicates(const TCondition& condition)
} else if (op == "!*=") {
op = "!=";
}
- condition_str = condition.column_name + op + condition.condition_values[0];
+ condition_str = condition.column_name + op + "'" + condition.condition_values[0] + "'";
Review Comment:
If we upgrade from doris 1.2 and there is a delete condition. It does not contains '', is there error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20349:
URL: https://github.com/apache/doris/pull/20349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #20349:
URL: https://github.com/apache/doris/pull/20349#issuecomment-1572910316
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #20349:
URL: https://github.com/apache/doris/pull/20349#discussion_r1213815003
##########
be/src/olap/delete_handler.cpp:
##########
@@ -110,7 +110,7 @@ std::string DeleteHandler::construct_sub_predicates(const TCondition& condition)
} else if (op == "!*=") {
op = "!=";
}
- condition_str = condition.column_name + op + condition.condition_values[0];
+ condition_str = condition.column_name + op + "'" + condition.condition_values[0] + "'";
Review Comment:
because it already save the previous condition does not have '' in data file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20349:
URL: https://github.com/apache/doris/pull/20349#issuecomment-1572241297
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20349: [fix](olap) deletion statement with space conditions did not take effect
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20349:
URL: https://github.com/apache/doris/pull/20349#issuecomment-1572912770
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org