You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Pawel Pastula (JIRA)" <ji...@codehaus.org> on 2006/02/23 10:30:36 UTC
[jira] Created: (MPJAR-53) [JarSignMojo] Verification of a signed
jar fails
[JarSignMojo] Verification of a signed jar fails
------------------------------------------------
Key: MPJAR-53
URL: http://jira.codehaus.org/browse/MPJAR-53
Project: maven-jar-plugin
Type: Bug
Environment: Linux Slackware 10.1, JDK 1.4.2_02
Reporter: Pawel Pastula
Priority: Blocker
When verification is executed there is no way the verification can succeed since if uses unsigned jar file instead of signedjar file:
verify.setJarPath( getJarFile() ); in JarSignMojo.java:182.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MJAR-32) [JarSignMojo] Verification of a signed
jar fails
Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-32?page=all ]
Jerome Lacoste updated MJAR-32:
-------------------------------
Attachment: MJAR-32.diff
> [JarSignMojo] Verification of a signed jar fails
> ------------------------------------------------
>
> Key: MJAR-32
> URL: http://jira.codehaus.org/browse/MJAR-32
> Project: Maven 2.x Jar Plugin
> Type: Bug
> Environment: Linux Slackware 10.1, JDK 1.4.2_02
> Reporter: Pawel Pastula
> Priority: Blocker
> Attachments: MJAR-32.diff
>
>
> When verification is executed there is no way the verification can succeed since if uses unsigned jar file instead of signedjar file:
> verify.setJarPath( getJarFile() ); in JarSignMojo.java:182.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MJAR-32) [JarSignMojo] Verification of a signed
jar fails
Posted by "Pawel Pastula (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-32?page=comments#action_59324 ]
Pawel Pastula commented on MJAR-32:
-----------------------------------
There is also one thing I forgot in my last comment.
To enable in-place jar signing, the field signedjar must not be @requiered.
Right now tests are working fine but there is no way to do it in practise.
I had removed @requiered attribute and have been struggling with pom.xml to make it work.
The "default-value" makes it difficult to set null value. I don't know maven2 well but if there is no way to set this plugin's attribute to null then I think signedjar should be String not java.io.File.
I tried:
<signedjar/> and thoutht it could set signedjar to null - but the default value is set
I also tried:
<signedjar implementation="java.io.File">null</signedjar> but creates File("null") :-)
How can one set this field to null to enable in-place jar signing ?
> [JarSignMojo] Verification of a signed jar fails
> ------------------------------------------------
>
> Key: MJAR-32
> URL: http://jira.codehaus.org/browse/MJAR-32
> Project: Maven 2.x Jar Plugin
> Type: Bug
> Environment: Linux Slackware 10.1, JDK 1.4.2_02
> Reporter: Pawel Pastula
> Priority: Blocker
> Attachments: MJAR-32.diff
>
>
> When verification is executed there is no way the verification can succeed since if uses unsigned jar file instead of signedjar file:
> verify.setJarPath( getJarFile() ); in JarSignMojo.java:182.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MJAR-32) [JarSignMojo] Verification of a signed
jar fails
Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-32?page=comments#action_59309 ]
Jerome Lacoste commented on MJAR-32:
------------------------------------
Working on it...
> [JarSignMojo] Verification of a signed jar fails
> ------------------------------------------------
>
> Key: MJAR-32
> URL: http://jira.codehaus.org/browse/MJAR-32
> Project: Maven 2.x Jar Plugin
> Type: Bug
> Environment: Linux Slackware 10.1, JDK 1.4.2_02
> Reporter: Pawel Pastula
> Priority: Blocker
>
>
> When verification is executed there is no way the verification can succeed since if uses unsigned jar file instead of signedjar file:
> verify.setJarPath( getJarFile() ); in JarSignMojo.java:182.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MJAR-32) [JarSignMojo] Verification of a signed
jar fails
Posted by "Pawel Pastula (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-32?page=comments#action_59321 ]
Pawel Pastula commented on MJAR-32:
-----------------------------------
After applying your patch, some tests fail.
To be precise it's: testVerifyInPlaceSignedJar
when you invoke:
mojo.setSignedJar( null );
you will get NPE in JarSignMojo.java:221:
addArgIfNotEmpty( arguments, "-signedjar", this.signedjar.getPath() );
Here is the solution to this problem:
addArgIfNotEmpty( arguments, "-signedjar", this.signedjar != null ? this.signedjar.getPath() : null );
I didn't attach a patch since I don't know to which revision this patch should be applied.
> [JarSignMojo] Verification of a signed jar fails
> ------------------------------------------------
>
> Key: MJAR-32
> URL: http://jira.codehaus.org/browse/MJAR-32
> Project: Maven 2.x Jar Plugin
> Type: Bug
> Environment: Linux Slackware 10.1, JDK 1.4.2_02
> Reporter: Pawel Pastula
> Priority: Blocker
> Attachments: MJAR-32.diff
>
>
> When verification is executed there is no way the verification can succeed since if uses unsigned jar file instead of signedjar file:
> verify.setJarPath( getJarFile() ); in JarSignMojo.java:182.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org