You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/27 16:26:59 UTC
[GitHub] [arrow] pitrou opened a new pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
pitrou opened a new pull request #10416:
URL: https://github.com/apache/arrow/pull/10416
We're currently using a dedicated Github Actions to cancel previous jobs when a new job is queued. It seems this now can be done better using the "concurrency" setting (unfortunately in beta):
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-851341284
> > If I understand correctly this change should cancel pull request builds as well, like subsequent pushes to the same PR.
>
> Yep
Thanks for confirming it! Let's try it out then, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-855949193
Uh, it seems this may not be working as expected. Here is a unexpectedly cancelled job:
https://github.com/apache/arrow/actions/runs/914966579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849946499
Great!
The configuration cancels pending jobs for the master branch, right?
I think that it's better that we don't cancel jobs for the master branch. (We may be able to use `github.event.number` for it. It'll be a number for pull requests and `null` for the master branch.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849773671
Note I've checked this on my fork but PR runs may be slightly different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849966802
> (We may be able to use `github.event.number` for it. It'll be a number for pull requests and `null` for the master branch.)
Ah, this doesn't help. Please ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] potiuk commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-851320624
> If I understand correctly this change should cancel pull request builds as well, like subsequent pushes to the same PR.
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] potiuk commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849776555
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10416:
URL: https://github.com/apache/arrow/pull/10416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849797617
https://issues.apache.org/jira/browse/ARROW-12895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-855957069
Perhaps that's because the `pull_request_target` event doesn't fill the `github.*` variables similarly as the `pull_request` event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-851319673
> The configuration cancels pending jobs for the master branch, right?
If I understand correctly this change should cancel pull request builds as well, like subsequent pushes to the same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849772629
Note that the "cancel stale runs" workflow is run from git master, so removing it will only be effective once this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-849773327
cc @potiuk FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10416: ARROW-12895: [CI] Use "concurrency" setting on Github Actions to cancel stale jobs
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10416:
URL: https://github.com/apache/arrow/pull/10416#issuecomment-855964764
Fix filed in https://github.com/apache/arrow/pull/10467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org