[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2666: Add check for ReplicationTable online status in Monitor

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2666:
URL: https://github.com/apache/accumulo/pull/2666#discussion_r862212463


##########
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java:
##########
@@ -149,6 +149,12 @@ public List<ReplicationInformation> getReplicationInformation()
       });
     }
 
+    //Ensure replication table is online before attempting to create BatchScanner
+    if (!ReplicationTable.isOnline(client)) {
+        log.error("Replication table is offline");

Review Comment:
   I suspect the formatter will add a space when it builds. I enabled a build on this PR, so we'll find out.
   
   The message can also be a debug instead of an error, since this is probably a normal situation (it's not a problem if the user clicks the page).
   
   ```suggestion
       // Ensure replication table is online before attempting to create BatchScanner
       if (!ReplicationTable.isOnline(client)) {
           log.debug("Replication page requested, but replication table is offline");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org