[GitHub] [incubator-milagro-crypto-c] jaromil commented on issue #32: Miller loop test fail in Zenroom using BLS383

[GitBox <gi...@apache.org>]

jaromil commented on issue #32: Miller loop test fail in Zenroom using BLS383
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/32#issuecomment-517983739
 
 
   Hi Kealan, thanks for your reply! about the Miller Loop test on BLS383 (the only curve I can easily test right now in Zenroom), I confirm the non-deterministic failure of the test (passes once ever 4 or 5 execution times) also with the current develop branch. Zenroom code used for the test:
   ```lua
   ECP = require('zenroom_ecp')
   ECP2 = require('zenroom_ecp2')
   G1 = ECP.generator()
   G2 = ECP2.generator()
   r = ECP.order()
   -- generate a big random number of maximum INT size and apply modulo of the curve's order  
   function R() return INT.modrand(r) end
   P1 = G1 * R() -- Pick a random point in G1
   Q1 = G2 * R() -- Pick a random point in G2
   -- Test that miller(sQ,P) = miller(Q,P)^s, s random"
   s = R()
   g1 = ECP2.miller( Q1*s, P1)
   g2 = ECP2.miller( Q1, P1)^s
   assert(g1 == g2)
   ```
   
   About the other points, in the hope are useful, hereby my opinions:
   1. Publish an annotated diff of the repository history pre and post ASF, eliminating cosmetic changes (whitespace and emails) and build system changes, to focus on what changes in the code between the last commit on "version 4" and the first commit on the new repo.
   2. Milagro is wonderful in many ways, one of them is that it is a generic base library for crypto providing choice among a number of curves. If it is no effort to maintain "old" curves then I recommend keeping them around. It is also what made OpenSSL dominate the scene so far so this is mostly a strategic choice, if at par with effort.
   2a. If there would be anything that I'd shave off Milagro that would be RSA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org