You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 20:03:35 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19528: Fix missing dagruns when catchup=True

ephraimbuddy commented on a change in pull request #19528:
URL: https://github.com/apache/airflow/pull/19528#discussion_r746945206



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -1274,7 +1274,8 @@ def test_dagrun_timeout_fails_run_and_update_next_dagrun(self, dag_maker):
         session.flush()
         session.refresh(dr)
         assert dr.state == State.FAILED
-        # check that next_dagrun has been updated by Schedulerjob._update_dag_next_dagruns
+        self.scheduler_job._do_scheduling(session)

Review comment:
       I'm not sure if this test is correct or not, the assert below was failing, that was why I made the change here. Could be another bug, please review




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org