You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ih...@apache.org on 2012/05/29 13:49:55 UTC

svn commit: r1343684 - in /logging/log4php/trunk/src: main/php/LoggerAutoloader.php main/php/appenders/LoggerAppenderFirePHP.php site/xdoc/docs/appenders/firephp.xml test/php/appenders/LoggerAppenderFirephpTest.php

Author: ihabunek
Date: Tue May 29 11:49:54 2012
New Revision: 1343684

URL: http://svn.apache.org/viewvc?rev=1343684&view=rev
Log:
Missed several occurances of LoggerAppenderFirephp, renamed to LoggerAppenderFirePHP. Improved docs.

Modified:
    logging/log4php/trunk/src/main/php/LoggerAutoloader.php
    logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirePHP.php
    logging/log4php/trunk/src/site/xdoc/docs/appenders/firephp.xml
    logging/log4php/trunk/src/test/php/appenders/LoggerAppenderFirephpTest.php

Modified: logging/log4php/trunk/src/main/php/LoggerAutoloader.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/LoggerAutoloader.php?rev=1343684&r1=1343683&r2=1343684&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/LoggerAutoloader.php (original)
+++ logging/log4php/trunk/src/main/php/LoggerAutoloader.php Tue May 29 11:49:54 2012
@@ -63,7 +63,7 @@ class LoggerAutoloader {
 		'LoggerAppenderMailEvent' => '/appenders/LoggerAppenderMailEvent.php',
 		'LoggerAppenderMongoDB' => '/appenders/LoggerAppenderMongoDB.php',
 		'LoggerAppenderNull' => '/appenders/LoggerAppenderNull.php',
-		'LoggerAppenderFirephp' => '/appenders/LoggerAppenderFirephp.php',
+		'LoggerAppenderFirePHP' => '/appenders/LoggerAppenderFirePHP.php',
 		'LoggerAppenderPDO' => '/appenders/LoggerAppenderPDO.php',
 		'LoggerAppenderPhp' => '/appenders/LoggerAppenderPhp.php',
 		'LoggerAppenderRollingFile' => '/appenders/LoggerAppenderRollingFile.php',

Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirePHP.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirePHP.php?rev=1343684&r1=1343683&r2=1343684&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirePHP.php (original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirePHP.php Tue May 29 11:49:54 2012
@@ -39,7 +39,7 @@
  * @subpackage appenders
  * @since 2.3
  */
-class LoggerAppenderFirephp extends LoggerAppender {
+class LoggerAppenderFirePHP extends LoggerAppender {
 	
 	/**
 	 * Instance of the Insight console class.

Modified: logging/log4php/trunk/src/site/xdoc/docs/appenders/firephp.xml
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/site/xdoc/docs/appenders/firephp.xml?rev=1343684&r1=1343683&r2=1343684&view=diff
==============================================================================
--- logging/log4php/trunk/src/site/xdoc/docs/appenders/firephp.xml (original)
+++ logging/log4php/trunk/src/site/xdoc/docs/appenders/firephp.xml Tue May 29 11:49:54 2012
@@ -25,9 +25,18 @@
 	<body>
 		<section name="LoggerAppenderFirePHP">
 		
-			<p><code>LoggerAppenderFirePHP</code> logs events by creating a PHP user-level message using the Browser-Extension
-			<code><a href="http://www.firephp.org/" target="_blank" 
-			class="externalLink">FirePHP</a></code></p>
+			<p><code>LoggerAppenderFirePHP</code> logs events via the 
+				<a href="http://www.firephp.org/" target="_blank">FirePHP</a> serverside library. The messages are 
+				logged in HTTP headers and can be viewed using the <a target="_blank" 
+				href="http://developercompanion.com/">Developer compainion</a> plugin for Firefox.</p>
+		
+			<p>Requires the FirePHP server-side library 1.0 or greater. Download it from <a target="_blank" 
+				href="http://sourcemint.com/github.com/firephp/firephp/1:1.0.0b1rc6/-docs/Welcome">here</a>.</p>
+				
+			<div class="alert">
+				<strong>Warning!</strong> This appender is still experimental. Behaviour may change in future versions
+				without notification.
+			</div>
 		
 			<subsection name="Layout">
 				<p>This appender requires a layout. If no layout is specified in configuration, 
@@ -35,11 +44,33 @@
 			</subsection>	
 		
 			<subsection name="Parameters">
-				<p>This appender has no configurable parameters.</p>
+				<p>The following parameters are available:</p>
+		
+				<table>
+					<thead>
+						<tr>
+							<th>Parameter</th>
+							<th>Type</th>
+							<th>Required</th>
+							<th>Default</th>
+							<th>Description</th>
+						</tr>
+					</thead>
+					<tbody>
+						<tr>
+							<td>target</td>
+							<td>string</td>
+							<td>No</td>
+							<td>page</td>
+							<td>The target to which messages will be sent. Possible options are 'page' (default), 
+								'request', 'package' and 'controller'. For more details, see FirePHP 
+								documentation.</td>
+						</tr>
+					</tbody>
+				</table>
 			</subsection>
-				
 			<subsection name="Examples">
-
+				<p>Sample configuration:</p>
 				<div class="auto-tabs">
 					<ul>
 						<li>XML</li>

Modified: logging/log4php/trunk/src/test/php/appenders/LoggerAppenderFirephpTest.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/test/php/appenders/LoggerAppenderFirephpTest.php?rev=1343684&r1=1343683&r2=1343684&view=diff
==============================================================================
--- logging/log4php/trunk/src/test/php/appenders/LoggerAppenderFirephpTest.php (original)
+++ logging/log4php/trunk/src/test/php/appenders/LoggerAppenderFirephpTest.php Tue May 29 11:49:54 2012
@@ -29,7 +29,7 @@
 /**
  * @group appenders
  */
-class LoggerAppenderFirephpTest extends PHPUnit_Framework_TestCase {
+class LoggerAppenderFirePHPTest extends PHPUnit_Framework_TestCase {
 
 	private $config = array(
 		'rootLogger' => array(
@@ -37,7 +37,7 @@ class LoggerAppenderFirephpTest extends 
 		),
 		'appenders' => array(
 			'default' => array(
-				'class' => 'LoggerAppenderFirephp',
+				'class' => 'LoggerAppenderFirePHP',
 				'layout' => array(
 					'class' => 'LoggerLayoutPattern',
 				),
@@ -53,13 +53,13 @@ class LoggerAppenderFirephpTest extends 
 	}
 	
 	private function createEvent($message, $level) {
-		$eventMock = new LoggerLoggingEvent("LoggerAppenderFirephpTest", new Logger("TEST"), LoggerLevel::toLevel($level), $message);
+		$eventMock = new LoggerLoggingEvent("LoggerAppenderFirePHPTest", new Logger("TEST"), LoggerLevel::toLevel($level), $message);
 	
 		return $eventMock;
 	}	
 	
 	public function testSetTarget() {
-		$appender = new LoggerAppenderFirephp();
+		$appender = new LoggerAppenderFirePHP();
 		$appender->setTarget('page');
 		self::assertSame('page', $appender->getTarget());
 	}
@@ -146,7 +146,7 @@ class LoggerAppenderFirephpTest extends 
 	}
 }
 
-class TestableLoggerAppenderFirePhp extends LoggerAppenderFirephp {
+class TestableLoggerAppenderFirePhp extends LoggerAppenderFirePHP {
 	public function setConsole($console) {
 		$this->console = $console;
 	}