You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/07 01:44:34 UTC
[GitHub] [incubator-ratis] amaliujia opened a new pull request #260: RATIS-1135. Initialize DataStreamServer after RaftServerProxy id is set
amaliujia opened a new pull request #260:
URL: https://github.com/apache/incubator-ratis/pull/260
## What changes were proposed in this pull request?
Otherwise the `server.getId()` is `null` at https://github.com/apache/incubator-ratis/blob/189ee94471afdef8bd6c8b1fb419309230bfaa24/ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java#L221
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1135
## How was this patch tested?
UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #260: RATIS-1135. Initialize DataStreamServer after RaftServerProxy id is set
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #260:
URL: https://github.com/apache/incubator-ratis/pull/260#issuecomment-723385859
@runzhiwang thanks a lot for reviewing this.
@amaliujia , you may want to combine small change like this with another JIRA such as RATIS-1130. Otherwise, it will be inefficient.
Also, we would like to split a large change into multiple JIRAs. Otherwise, it is not easy to review. Changes with size (generated "git diff") between 10KB and 20KB probably is the optimal. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo merged pull request #260: RATIS-1135. Initialize DataStreamServer after RaftServerProxy id is set
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #260:
URL: https://github.com/apache/incubator-ratis/pull/260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #260: RATIS-1135. Initialize DataStreamServer after RaftServerProxy id is set
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #260:
URL: https://github.com/apache/incubator-ratis/pull/260#issuecomment-723387819
Thanks! The tip of 10KB and 20KB of a change is useful 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #260: RATIS-1135. Initialize DataStreamServer after RaftServerProxy id is set
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #260:
URL: https://github.com/apache/incubator-ratis/pull/260#issuecomment-723371425
R: @runzhiwang @szetszwo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org