You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "xiaocairush (via GitHub)" <gi...@apache.org> on 2023/06/20 12:00:28 UTC
[GitHub] [kafka] xiaocairush opened a new pull request, #13883: MINOR: Fix typos for doc
xiaocairush opened a new pull request, #13883:
URL: https://github.com/apache/kafka/pull/13883
*More detailed description of your change,
Fix some typos for documents
*Summary of testing strategy (including rationale)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13883: MINOR: Fix typos for doc
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1599501486
Also, @xiaocairush is it possible to automate testing for these spell typos in checkstyle of some other build plugin? What tool did you use to find these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on pull request #13883: MINOR: Fix typos for doc
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1600004067
@divijvaidya I'm using a tool called [typos](https://github.com/crate-ci/typos). And it can be integrated with GitHub Actions. But I don't sure if it's a good practice to intergrate with repos. Because it maybe fail the CI more frequently. Maybe it's more efficient to correct typos monthly by the tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13883: MINOR: Fix typos for doc
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1600374520
> Besides, how do you ensure there is not some people work on the same issue simultaneously in jira when the issue is not assigned. Seems like I need a jira account to assign issue to myself?
Yes, we use JIRA and you can create one using the instruction at https://kafka.apache.org/contributing
> I'm using a tool called [typos](https://github.com/crate-ci/typos). And it can be integrated with GitHub Actions. But I'm sure if it's a good practice to intergrate with repo.
Yeah, perhaps not with github actions. I am hoping checkstyle comes up with something similar. I honestly haven't looked into automated spell checks before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13883: MINOR: Fix typos for doc
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1599479499
please rebase with trunk, #13882 has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya merged pull request #13883: MINOR: Fix typos for doc
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #13883:
URL: https://github.com/apache/kafka/pull/13883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on pull request #13883: MINOR: Fix typos for doc
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1600024221
Besides, how do you ensure there is not some people work on the same issue simultaneously in jira when the issue is not assigned. Seems like I need a jira account to assign issue to myself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on pull request #13883: MINOR: Fix typos for doc
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1598643673
sorry for that commit so many changes. Please review https://github.com/apache/kafka/pull/13882 first. When that PR is merged then the change will be only in doc module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org