You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/02/23 22:57:27 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #34295: GH-25025: [C++] Build core compute kernels unconditionally

westonpace commented on code in PR #34295:
URL: https://github.com/apache/arrow/pull/34295#discussion_r1116332440


##########
cpp/src/arrow/compute/kernels/CMakeLists.txt:
##########
@@ -18,10 +18,11 @@
 # ----------------------------------------------------------------------
 # Scalar kernels
 
+add_arrow_compute_test(scalar_cast_test SOURCES scalar_cast_test.cc test_util.cc)

Review Comment:
   Why did you peel this off into its own test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org