[GitHub] [airflow] uranusjr commented on a change in pull request #19789: Fix missing region_name arguments in AWS provider

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #19789:
URL: https://github.com/apache/airflow/pull/19789#discussion_r755464410



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -539,7 +539,7 @@ def expand_role(self, role: str) -> str:
         if "/" in role:
             return role
         else:
-            session, endpoint_url = self._get_credentials()
+            session, endpoint_url = self._get_credentials(region_name=None)

Review comment:
       Do we want to add `region_name` to this?

##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -539,7 +539,7 @@ def expand_role(self, role: str) -> str:
         if "/" in role:
             return role
         else:
-            session, endpoint_url = self._get_credentials()
+            session, endpoint_url = self._get_credentials(region_name=None)

Review comment:
       Do we want to add `region_name` to `expand_role`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org