You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/17 22:44:16 UTC
[GitHub] Juice10 opened a new issue #872: Docs still recommend deprecated
`manifest.yaml` definitions
Juice10 opened a new issue #872: Docs still recommend deprecated `manifest.yaml` definitions
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/872
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/743 removed the deprecated `package:` parameter from the `manifest.yml` but the docs where never updated to reflect that.
These docs still refer to the old `package:` definition of the `manifest.yaml`:
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/docs/wskdeploy_package_minimal.md#packages
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/docs/examples/manifest_package_minimal.yaml
eg.
```yaml
package:
name: hello_world_package
version: 1.0
license: Apache-2.0
```
When I try running that I get all kinds of errors.
```
$ ./wskdeploy
Info: The API host is [10.11.71.125:443], from .wskprops.
Info: The auth key is set, from .wskprops.
Info: The namespace is [guest], from .wskprops.
Info: The apigw access token is set, from .wskprops.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x28b27c]
goroutine 1 [running]:
github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk.GetUrlBase(0x10a9a968, 0x10, 0x7f, 0x0, 0x0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk/wskprops.go:72 +0xac
github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk.NewClient(0x10a9ab20, 0x10aa2050, 0x58d1ec, 0x10aa2050, 0x0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/apache/incubator-openwhisk-client-go/whisk/client.go:129 +0x6a7
github.com/apache/incubator-openwhisk-wskdeploy/deployers.glob..func5(0x10aa2050, 0x17, 0x0, 0x0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/deployers/whiskclient.go:80 +0x3f
github.com/apache/incubator-openwhisk-wskdeploy/cmd.Deploy(0x1, 0x109971e4)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:202 +0x3b9
github.com/apache/incubator-openwhisk-wskdeploy/cmd.RootCmdImp(0x57a3c0, 0x58d1ec, 0x0, 0x0, 0x0, 0x0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:50 +0x14
github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).execute(0x57a3c0, 0x10996018, 0x0, 0x0, 0x57a3c0, 0x10996018)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:632 +0x2df
github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x57a3c0, 0x3aab11, 0x0, 0x0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:722 +0x285
github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra.(*Command).Execute(0x57a3c0, 0x109f8450, 0x1091c0f0)
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/vendor/github.com/spf13/cobra/command.go:681 +0x1b
github.com/apache/incubator-openwhisk-wskdeploy/cmd.Execute()
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:56 +0x1d
main.main()
/home/travis/gopath/src/github.com/apache/incubator-openwhisk-wskdeploy/main.go:26 +0x11
```
Might be a good idea to also add validation to the `manifest.yaml` file so we don't give crash whenever they have an outdated `manifest.yml` but inform them in a nicer way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services