You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/17 00:36:04 UTC
[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)
ppkarwasz opened a new pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710
The Log4j 1.x bridge incorrectly sets the pattern of the rolling file appenders. Moreover the `RollingFileAppender` did not have a time based triggering policy in the original Log4j 1.x.
The triggering policies in this PR are configured in the same way as in the `Log4j1ConfigurationFactory`, i.e. with a useless `CompositeTriggeringPolicy`.
This PR is linked with the tests in #706.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory closed pull request #710: Log4j 1.2 bridge uses the wrong file pattern for rolling file appenders
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #710: Log4j 1.2 bridge uses the wrong file pattern for rolling file appenders
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1018024520
@ppkarwasz
Thank you for your updates. I brought in this PR with these changes:
- Add the Apache license header to XML test fixtures.
- Remove unused imports.
- Add missing spaces in Java source.
- Remove some whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1017933371
@garydgregory: done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #710: Corrects the file pattern of the rolling appenders (Log4j 1.x bridge)
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710#issuecomment-1017618892
@ppkarwasz
Please rebase on branch `release-2.x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org