[jira] [Commented] (FLINK-5390) input should be closed in finally block in YarnFlinkApplicationMasterRunner#loadJobGraph()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802256#comment-15802256 ] 

ASF GitHub Bot commented on FLINK-5390:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3045
  
    I think this is good, merging this...


> input should be closed in finally block in YarnFlinkApplicationMasterRunner#loadJobGraph()
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-5390
>                 URL: https://issues.apache.org/jira/browse/FLINK-5390
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Roman Maier
>            Priority: Minor
>
> {code}
>         FileInputStream input = new FileInputStream(fp);
>         ObjectInputStream obInput = new ObjectInputStream(input);
>         jg = (JobGraph) obInput.readObject();
>         input.close();
> {code}
> If readObject() throws exception, input would be left unclosed.
> Similar issue is in AbstractYarnClusterDescriptor#startAppMaster() around line 726.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)