You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2021/02/10 16:01:23 UTC
[skywalking] 01/01: Temporarily remove `testErrorProtocol` case.
Can't pass on my MacOS.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch remove
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit d3422a02b3cf34340f421c7e31e008eca523af20
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Feb 11 00:00:51 2021 +0800
Temporarily remove `testErrorProtocol` case. Can't pass on my MacOS.
---
.../protocol/ZabbixProtocolHandlerTest.java | 24 ----------------------
1 file changed, 24 deletions(-)
diff --git a/oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/protocol/ZabbixProtocolHandlerTest.java b/oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/protocol/ZabbixProtocolHandlerTest.java
index 749699f..be4d7eb 100644
--- a/oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/protocol/ZabbixProtocolHandlerTest.java
+++ b/oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/protocol/ZabbixProtocolHandlerTest.java
@@ -62,28 +62,4 @@ public class ZabbixProtocolHandlerTest extends ZabbixBaseTest {
stopSocketClient();
}
-
- /**
- * Test error protocol
- */
- @Test
- public void testErrorProtocol() throws Throwable {
- // Simple header
- for (int i = 1; i < 5; i++) {
- assertNeedMoreInput(new byte[i]);
- }
-
- // Only header string
- assertNeedMoreInput(new byte[] {'Z', 'B', 'X', 'D'});
-
- // Header error
- assertWriteErrorProtocol(new byte[] {'Z', 'B', 'X', 'D', 2, 0, 0, 0, 0});
- assertWriteErrorProtocol(new byte[] {'Z', 'B', 'X', 'D', 2, 1, 0, 0, 0});
-
- // Empty data
- assertWriteErrorProtocol(SocketClient.buildZabbixRequestData(""));
- assertWriteErrorProtocol(SocketClient.buildZabbixRequestData("{}"));
- assertWriteErrorProtocol(SocketClient.buildZabbixRequestData("{\"test\": 1}"));
- }
-
}